Paths

Table of Contentst

Differential D10473

[web] rename navigation sidebar tooltip to label tooltip
ClosedPublic
Actions

Authored by ginsu on Dec 27 2023, 9:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 8 2024, 6:47 AM

	Unknown Object (File)
	Apr 4 2024, 12:30 PM

	Unknown Object (File)
	Apr 4 2024, 12:30 PM

	Unknown Object (File)
	Apr 4 2024, 12:30 PM

	Unknown Object (File)
	Apr 4 2024, 12:29 PM

	Unknown Object (File)
	Apr 4 2024, 12:28 PM

	Unknown Object (File)
	Feb 20 2024, 7:33 AM

	Unknown Object (File)
	Feb 20 2024, 7:07 AM

View All 22 Files

Subscribers

Details

Reviewers

atul
kamil
rohan

Commits

rCOMMeb9f85f86b0c: [web] rename navigation sidebar tooltip to label tooltip

Summary

Rename diff. In D10472, I extended the api of the navigation sidebar tooltip so that this tooltip can be better reused in other places in the web app. Now that this tooltip is more generic, I decided to rename this tooltip into label tooltip since this tooltip just shows a floating label for the element that is hovered over

Depends on D10472

Test Plan

flow and confirmed that this tooltip has no regressions

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 27 2023, 9:54 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 27 2023, 9:54 PM

ginsu edited the summary of this revision. (Show Details)Dec 27 2023, 9:54 PM

ginsu added reviewers: atul, kamil, rohan.

ginsu added a parent revision: D10472: [web] extend navigation sidebar tooltip api.

ginsu added a child revision: D10474: [web] cleanup and better organize code for tooltips.Dec 27 2023, 10:02 PM

Harbormaster completed remote builds in B25361: Diff 35040.Dec 27 2023, 10:13 PM

ginsu requested review of this revision.Dec 27 2023, 10:13 PM

atul accepted this revision.Dec 28 2023, 4:41 PM

This revision is now accepted and ready to land.Dec 28 2023, 4:41 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 28 2023, 6:46 PM

Closed by commit rCOMMeb9f85f86b0c: [web] rename navigation sidebar tooltip to label tooltip (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMeb9f85f86b0c: [web] rename navigation sidebar tooltip to label tooltip.

Harbormaster completed remote builds in B25388: Diff 35069.Dec 28 2023, 7:06 PM

Revision Contents
Changeset List

Path

Size

web/

navigation-sidebar/

account-settings-button.react.js

4 lines

community-creation-button.react.js

4 lines

community-list-item.react.js

4 lines

	label-toolitp.react.js
	navigation-sidebar-toolitp.react.js

10 lines

	label-tooltip.css
	navigation-sidebar-tooltip.css

navigation-sidebar-constants.js

2 lines

navigation-sidebar-home-button.react.js

4 lines

navigation-sidebar-toolitp.react.js

navigation-sidebar-tooltip.css

utils/

tooltip-action-utils.js

24 lines

tooltip-utils.js

8 lines

Diff 35078

web/navigation-sidebar/account-settings-button.react.js

Loading...

web/navigation-sidebar/community-creation-button.react.js

Loading...

web/navigation-sidebar/community-list-item.react.js

Loading...

web/navigation-sidebar/label-toolitp.react.js

Loading...

web/navigation-sidebar/label-tooltip.css

Loading...

web/navigation-sidebar/navigation-sidebar-constants.js

Loading...

web/navigation-sidebar/navigation-sidebar-home-button.react.js

Loading...

web/navigation-sidebar/navigation-sidebar-toolitp.react.js

Loading...

web/navigation-sidebar/navigation-sidebar-tooltip.css

Loading...

web/utils/tooltip-action-utils.js

Loading...

web/utils/tooltip-utils.js

Loading...