Paths

Table of Contentst

Differential D10501

[terraform] [services] [8/n] Add lambda trigger for reserved usernames
ClosedPublic
Actions

Authored by will on Jan 1 2024, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 11:05 PM

	Unknown Object (File)
	Sat, Nov 9, 12:40 PM

	Unknown Object (File)
	Oct 14 2024, 11:26 PM

	Unknown Object (File)
	Oct 14 2024, 11:26 PM

	Unknown Object (File)
	Oct 14 2024, 11:26 PM

	Unknown Object (File)
	Oct 14 2024, 11:25 PM

	Unknown Object (File)
	Oct 14 2024, 11:25 PM

	Unknown Object (File)
	Oct 14 2024, 11:25 PM

Subscribers

Details

Reviewers

bartek
varun

Commits

rCOMM593eaf300c4f: [terraform] [services] [8/n] Add lambda trigger for reserved usernames

Summary

This adds an event trigger to have the lambda function add userID and usernames

Test Plan

Tested on staging with successful insertion

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jan 1 2024, 9:31 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 1 2024, 9:31 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 1 2024, 9:37 PM

Harbormaster failed remote builds in B25417: Diff 35118!

Rebase resolve build errors

Harbormaster completed remote builds in B25466: Diff 35180.Jan 3 2024, 5:43 PM

will requested review of this revision.Jan 3 2024, 5:43 PM

will added 1 blocking reviewer(s): varun.Jan 4 2024, 1:32 PM

varun requested changes to this revision.Jan 4 2024, 3:17 PM

varun added inline comments.

services/terraform/remote/aws_iam.tf
260 ↗	(On Diff #35180)	the `read_identity_users_stream` policy document includes the resource `module.shared.dynamodb_tables["identity-users"].arn`. why don't we have an equivalent resource here?
266 ↗	(On Diff #35180)	why do we need a new iam policy? can't we use a single policy for reading both streams?

This revision now requires changes to proceed.Jan 4 2024, 3:17 PM

will added inline comments.Jan 4 2024, 3:45 PM

services/terraform/remote/aws_iam.tf
260 ↗	(On Diff #35180)	After testing, this resource arn doesn't seem to be necessary for the lambda to read the stream records. I'll need to remove its equivalent for identity-users before landing.
266 ↗	(On Diff #35180)	We definitely can. I'll combine them

Combine reserved username stream policy into identity users policy

Harbormaster completed remote builds in B25522: Diff 35254.Jan 4 2024, 8:19 PM

bartek accepted this revision.Jan 5 2024, 2:06 AM

will updated this revision to Diff 35300.Jan 5 2024, 11:19 AM

This comment was removed by will.

will planned changes to this revision.Jan 5 2024, 11:22 AM

Revert last diff

Harbormaster completed remote builds in B25545: Diff 35300.Jan 5 2024, 11:47 AM

will added a child revision: D10559: [docs] [services] [9/n] Change docs and script to start docker-composed based localstack.Jan 5 2024, 12:10 PM

Harbormaster completed remote builds in B25546: Diff 35301.Jan 5 2024, 12:24 PM

will planned changes to this revision.Jan 5 2024, 7:54 PM

Rebase

will planned changes to this revision.Jan 16 2024, 11:09 AM

Harbormaster failed remote builds in B25812: Diff 35687!Jan 16 2024, 11:19 AM

rebase

Harbormaster completed remote builds in B25814: Diff 35689.Jan 16 2024, 1:36 PM

will added 1 blocking reviewer(s): varun.Jan 16 2024, 2:21 PM

will removed a reviewer: varun.Jan 16 2024, 3:48 PM

This revision is now accepted and ready to land.Jan 16 2024, 3:48 PM

will added a reviewer: varun.Jan 16 2024, 4:03 PM

This revision now requires review to proceed.Jan 16 2024, 4:03 PM

Rebase

Harbormaster completed remote builds in B25816: Diff 35691.Jan 16 2024, 4:27 PM

varun accepted this revision.Jan 16 2024, 10:05 PM

This revision is now accepted and ready to land.Jan 16 2024, 10:05 PM

Closed by commit rCOMM593eaf300c4f: [terraform] [services] [8/n] Add lambda trigger for reserved usernames (authored by will). · Explain WhyJan 17 2024, 10:49 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM593eaf300c4f: [terraform] [services] [8/n] Add lambda trigger for reserved usernames.

Revision Contents
Changeset List

Path

Size

services/

terraform/

modules/

shared/

8 lines

1 line

search_index_lambda.tf

6 lines

remote/

3 lines

Diff 35254

services/terraform/modules/shared/dynamodb.tf

Loading...

services/terraform/modules/shared/outputs.tf

Loading...

services/terraform/modules/shared/search_index_lambda.tf

Loading...

services/terraform/remote/aws_iam.tf

Loading...