Page MenuHomePhabricator
Differential D10544

[RN72] Fix lint-staged
ClosedPublic
Actions

Authored by ashoat on Jan 4 2024, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 1:25 PM
Unknown Object (File)
Thu, Oct 3, 1:24 PM
Unknown Object (File)
Thu, Oct 3, 1:24 PM
Unknown Object (File)
Thu, Oct 3, 1:24 PM
Unknown Object (File)
Thu, Oct 3, 1:24 PM
Unknown Object (File)
Thu, Oct 3, 1:24 PM
Unknown Object (File)
Tue, Oct 1, 3:06 AM
Unknown Object (File)
Sun, Sep 8, 1:23 AM
View All 58 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM0409c049bfaa: [RN72] Fix lint-staged
Summary

This finally resolves ENG-1011. It's necessary because ESLint 8 has removed the CLIEngine class.

I got this logic from the lint-staged README.md file.

Depends on D10543

Test Plan
  1. Edit a file that is in .eslintignore but not .gitignore. I opted for some file in native/flow-typed
  2. Add a line that isn't formatted in a way that Prettier likes
  3. Confirm that lint-staged doesn't fix the file on commit
  4. Remove native/flow-typed from .eslintignore and try again. Confirm that this time, lint-staged fixes the file on commit

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 4 2024, 12:42 PM
Herald added a subscriber: tomek. · View Herald TranscriptJan 4 2024, 12:42 PM
ashoat added a child revision: D10545: [RN72] Update Jest Flow libdefs.Jan 4 2024, 12:53 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2024, 12:54 PM
Harbormaster failed remote builds in B25500: Diff 35217!
ashoat updated this revision to Diff 35221.Jan 4 2024, 1:40 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2024, 1:54 PM
Harbormaster failed remote builds in B25504: Diff 35221!
ashoat updated this revision to Diff 35225.Jan 4 2024, 1:57 PM

Rebase

Harbormaster completed remote builds in B25508: Diff 35225.Jan 4 2024, 2:16 PM
ashoat requested review of this revision.Jan 4 2024, 2:16 PM
atul accepted this revision.Jan 4 2024, 2:47 PM
This revision is now accepted and ready to land.Jan 4 2024, 2:47 PM
Closed by commit rCOMM0409c049bfaa: [RN72] Fix lint-staged (authored by ashoat). · Explain WhyJan 4 2024, 6:12 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM0409c049bfaa: [RN72] Fix lint-staged.

Revision Contents
Changeset List

PathSize
20 lines

Diff 35244

View Options

.lintstagedrc.js

Loading...