Paths

Table of Contentst

Differential D10612

[web] introduce user settings list
ClosedPublic
Actions

Authored by ginsu on Jan 11 2024, 9:50 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 6:14 AM

	Unknown Object (File)
	Wed, Nov 13, 6:14 AM

	Unknown Object (File)
	Wed, Nov 13, 6:14 AM

	Unknown Object (File)
	Wed, Nov 13, 6:14 AM

	Unknown Object (File)
	Oct 22 2024, 4:57 PM

	Unknown Object (File)
	Oct 13 2024, 11:49 PM

	Unknown Object (File)
	Oct 13 2024, 11:49 PM

	Unknown Object (File)
	Oct 13 2024, 11:48 PM

View All 53 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM426824c992e3: [web] introduce user settings list

Summary

This diff introduces the user settings list component. This component will be used to switch between the various comm user settings.

For context here is what the figma designs look like:

Linear task: https://linear.app/comm/issue/ENG-5952/settings-list-ui

Depends on D10611

Test Plan

Please see the screenshot below

Screenshot 2024-01-11 at 12.54.51 PM.png (1×440 px, 40 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 11 2024, 9:50 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 9:50 AM

ginsu edited the summary of this revision. (Show Details)Jan 11 2024, 9:55 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10611: [web] introduce user settings list item.

ginsu attached a referenced file: F1056063: Screenshot 2024-01-11 at 12.54.51 PM.png. (Show Details)

ginsu added inline comments.Jan 11 2024, 10:03 AM

web/settings/user-settings-list.react.js
14 ↗	(On Diff #35555)	Most of this logic is taken from `SettingsSwitcher`. I intentionally decided to not delete the code in `SettingsSwitcher` because I want to make sure that I can land this diff as is w/o worrying about creating regressions/breaking changes. To make it easy to review tho, I will point out where the duplicated logic is. https://linear.app/comm/issue/ENG-5963/remove-old-horizontal-app-list tracks removing the `SettingsSwitcher`
19–24 ↗	(On Diff #35555)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/settings-switcher.react.js#L16-L25
26–31 ↗	(On Diff #35555)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/settings-switcher.react.js#L37-L46
33–38 ↗	(On Diff #35555)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/settings-switcher.react.js#L59-L68
40–52 ↗	(On Diff #35555)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/settings-switcher.react.js#L48-L57C3

Harbormaster completed remote builds in B25714: Diff 35555.Jan 11 2024, 10:14 AM

ginsu requested review of this revision.Jan 11 2024, 10:14 AM

ginsu added a child revision: D10614: [web] introduce friend and block lists to user settings list.Jan 11 2024, 10:29 AM

atul accepted this revision.Jan 12 2024, 1:20 PM

atul added inline comments.

web/settings/user-settings-list.react.js
14 ↗	(On Diff #35555)	Thanks for including the Linear task!

This revision is now accepted and ready to land.Jan 12 2024, 1:20 PM

Closed by commit rCOMM426824c992e3: [web] introduce user settings list (authored by ginsu). · Explain WhyJan 18 2024, 9:27 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM426824c992e3: [web] introduce user settings list.

Revision Contents
Changeset List

Path

Size

web/

settings/

user-settings-list.css

10 lines

user-settings-list.react.js

92 lines

Diff 35804

web/settings/user-settings-list.css

Loading...

web/settings/user-settings-list.react.js

Loading...