Paths

Table of Contentst

Differential D10617

[web] introduce friend list panel
ClosedPublic
Actions

Authored by ginsu on Jan 11 2024, 4:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 24, 12:18 AM

	Unknown Object (File)
	Sun, Jun 23, 11:25 PM

	Unknown Object (File)
	Thu, Jun 20, 1:19 AM

	Unknown Object (File)
	Tue, Jun 11, 10:08 AM

	Unknown Object (File)
	Tue, Jun 11, 10:08 AM

	Unknown Object (File)
	Tue, Jun 11, 10:08 AM

	Unknown Object (File)
	Mon, Jun 10, 8:42 PM

	Unknown Object (File)
	Apr 8 2024, 6:55 AM

View All 28 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMMe6d0e1cfa86a: [web] introduce friend list panel

Summary

This diff introduces the friend list panel. This component will replace the friends list modal.

Linear task: https://linear.app/comm/issue/ENG-5955/flatten-friends-block-list-modals

Depends on D10614

Test Plan

Please see the demo video below

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 11 2024, 4:21 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 4:21 PM

ginsu edited the summary of this revision. (Show Details)Jan 11 2024, 4:24 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10614: [web] introduce friend and block lists to user settings list.

ginsu added inline comments.Jan 11 2024, 4:33 PM

web/settings/relationship/friend-list-panel.react.js
16 ↗	(On Diff #35568)	Most of this logic is taken from `FriendListModal`. I intentionally decided to not delete the code in `FriendListModal` because I want to make sure that I can land this diff as is w/o worrying about creating regressions/breaking changes. To make it easy to review tho, I will point out where the duplicated logic is. https://linear.app/comm/issue/ENG-6442/remove-friends-list-modal tracks removing the `FriendListModal`
17–35 ↗	(On Diff #35568)	https://github.com/CommE2E/comm/blob/master/web/settings/relationship/friend-list-modal.react.js#L13-L31
42–45 ↗	(On Diff #35568)	https://github.com/CommE2E/comm/blob/master/web/settings/relationship/friend-list-modal.react.js#L41-L43C28

Harbormaster completed remote builds in B25720: Diff 35568.Jan 11 2024, 4:46 PM

ginsu requested review of this revision.Jan 11 2024, 4:46 PM

Thanks for linking the Linear task!

This revision is now accepted and ready to land.Jan 12 2024, 1:44 PM

rebase before landing

Harbormaster completed remote builds in B25896: Diff 35791.Jan 18 2024, 9:20 AM

Closed by commit rCOMMe6d0e1cfa86a: [web] introduce friend list panel (authored by ginsu). · Explain WhyJan 18 2024, 9:27 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMe6d0e1cfa86a: [web] introduce friend list panel.

Revision Contents
Changeset List

Path

Size

web/

settings/

relationship/

friend-list-panel.react.js

87 lines

15 lines

user-list.react.js

2 lines

Diff 35807

web/settings/relationship/friend-list-panel.react.js

Loading...

web/settings/relationship/user-list.css

Loading...

web/settings/relationship/user-list.react.js

Loading...