Page MenuHomePhabricator
Differential D10839

[lib/native] lift staff provider into lib
ClosedPublic
Actions

Authored by ginsu on Jan 26 2024, 8:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 5:18 AM
Unknown Object (File)
Wed, Jul 3, 4:32 AM
Unknown Object (File)
Tue, Jul 2, 11:36 PM
Unknown Object (File)
Tue, Jul 2, 11:21 PM
Unknown Object (File)
Tue, Jul 2, 2:30 PM
Unknown Object (File)
Mon, Jul 1, 8:41 PM
Unknown Object (File)
Sun, Jun 30, 10:30 PM
Unknown Object (File)
Sun, Jun 30, 4:30 PM
View All 25 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM6025a259cd6f: [lib/native] lift staff provider into lib
Summary

As I was building the build info page for web, I noticed that the hasStaffUserLoggedIn only lives in native. To get this field into web we should lift the staff context provider into lib so that it can be used on both platforms. This diff lifts the staff provider into lib so that it can be used in both web and native

Depends on D10825

Test Plan

flow + confirmed that there were no regressions with native

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 26 2024, 8:18 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 26 2024, 8:18 AM
ginsu edited the summary of this revision. (Show Details)Jan 26 2024, 8:19 AM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10825: [native] consolidate staff context provider into one file.
ginsu added a child revision: D10840: [web] introduce build info panel.Jan 26 2024, 8:31 AM
Harbormaster completed remote builds in B26193: Diff 36175.Jan 26 2024, 8:39 AM
ginsu requested review of this revision.Jan 26 2024, 8:39 AM
atul accepted this revision.Jan 29 2024, 10:01 PM

confirmed that there were no regressions with native

Ideally we'd have a more specific test plan that goes into a few scenarios that were checked

This revision is now accepted and ready to land.Jan 29 2024, 10:01 PM
ginsu updated this revision to Diff 36466.Jan 31 2024, 12:45 PM

rebase

Harbormaster completed remote builds in B26376: Diff 36466.Jan 31 2024, 1:04 PM
Closed by commit rCOMM6025a259cd6f: [lib/native] lift staff provider into lib (authored by ginsu). · Explain WhyJan 31 2024, 1:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6025a259cd6f: [lib/native] lift staff provider into lib.

Revision Contents
Changeset List

PathSize
lib/
components/
native/
staff/
staff-provider.react.js
staff-context.provider.react.js
2 lines
native/
account/
3 lines
data/
2 lines
profile/
2 lines
2 lines
staff/

Diff 36471

View Options

lib/components/staff-provider.react.js

Loading...
View Options

native/account/logged-out-staff-info.react.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/profile/build-info.react.js

Loading...
View Options

native/root.react.js

Loading...
View Options

native/staff/staff-context.provider.react.js

Loading...