Details

Reviewers

michal
varun
kamil

Commits

rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS

Summary

Exposed UpdateDeviceList RPC to JS via JSI.

Depends on D10863.

Test Plan

Called the method from JS, console.logged the result.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 29 2024, 1:27 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 1:27 PM

bartek added a child revision: D10865: [native] Expose LogInSecondaryDevice RPC to JS.Jan 29 2024, 1:28 PM

Harbormaster failed remote builds in B26249: Diff 36260!Jan 29 2024, 1:48 PM

Fix broken rebase

Harbormaster completed remote builds in B26258: Diff 36269.Jan 29 2024, 3:33 PM

bartek published this revision for review.Jan 29 2024, 3:48 PM

kamil accepted this revision.Jan 31 2024, 10:52 AM

This revision is now accepted and ready to land.Jan 31 2024, 10:52 AM

Rebase

Harbormaster failed remote builds in B26485: Diff 36609!Feb 5 2024, 12:10 PM

Rebase on fix

Harbormaster failed remote builds in B26488: Diff 36612!Feb 5 2024, 1:13 PM

Rebase on fix

Harbormaster completed remote builds in B26490: Diff 36614.Feb 5 2024, 1:38 PM

Rebase before landing

Harbormaster completed remote builds in B26739: Diff 36971.Feb 12 2024, 9:16 AM

Closed by commit rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS. · Explain WhyFeb 12 2024, 9:26 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS.

[native] Expose UpdateDeviceList RPC to JS
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36977

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

[native] Expose UpdateDeviceList RPC to JSClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36977

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

[native] Expose UpdateDeviceList RPC to JS
ClosedPublic
Actions

Revision Contents
Changeset List