Page MenuHomePhabricator
Differential D10865

[native] Expose LogInSecondaryDevice RPC to JS
ClosedPublic
Actions

Authored by bartek on Jan 29 2024, 5:28 AM.
Tags
None
Referenced Files
F3643808: D10865.diff
Sat, Jan 4, 5:54 PM
Unknown Object (File)
Wed, Jan 1, 8:33 AM
Unknown Object (File)
Tue, Dec 24, 4:48 AM
Unknown Object (File)
Tue, Dec 24, 4:48 AM
Unknown Object (File)
Tue, Dec 24, 4:48 AM
Unknown Object (File)
Tue, Dec 24, 4:48 AM
Unknown Object (File)
Tue, Dec 24, 4:48 AM
Unknown Object (File)
Tue, Dec 24, 4:48 AM
View All 89 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
kamil
Commits
rCOMMc89026bc3b6d: [native] Expose LogInSecondaryDevice RPC to JS
Summary

Exposed LogInSecondaryDevice RPC to JS via JSI.

Depends on D10864.

Test Plan

Called the method from JS, console.logged the result.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 29 2024, 5:28 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 5:28 AM
Harbormaster failed remote builds in B26250: Diff 36261!Jan 29 2024, 5:49 AM
bartek added a child revision: D10871: Implement device list methods in IdentityServiceClient.Jan 29 2024, 7:09 AM
bartek updated this revision to Diff 36270.Jan 29 2024, 7:17 AM

Fix broken rebase

Harbormaster completed remote builds in B26259: Diff 36270.Jan 29 2024, 7:36 AM
bartek published this revision for review.Jan 29 2024, 7:48 AM
kamil accepted this revision.Jan 31 2024, 3:06 AM
This revision is now accepted and ready to land.Jan 31 2024, 3:06 AM
bartek added a parent revision: D10862: [identity] Implement RPC for secondary device registration.Feb 12 2024, 12:55 AM
bartek updated this revision to Diff 37299.Feb 16 2024, 2:11 AM

Rebase on AuthResponse

bartek removed a child revision: D10871: Implement device list methods in IdentityServiceClient.Feb 16 2024, 2:21 AM
Harbormaster completed remote builds in B26956: Diff 37299.Feb 16 2024, 2:27 AM
Closed by commit rCOMMc89026bc3b6d: [native] Expose LogInSecondaryDevice RPC to JS (authored by bartek). · Explain WhyFeb 16 2024, 6:26 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMc89026bc3b6d: [native] Expose LogInSecondaryDevice RPC to JS.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
12 lines
54 lines
_generated/
native_rust_library/
src/
121 lines
schema/
12 lines

Diff 37299

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...