Differential D10899
[web] introduce member list sidebar provider Authored by ginsu on Jan 31 2024, 1:15 PM. Tags None Referenced Files
Details
The chat member list sidebar needs to be able to open + close from different points in the app. We will use showMemberListSidebar to track when the member list is open or close. Since we need to keep track of this state and use it many places, rather than prop drill this state to different places we should introduce a context provider that can be consumed in all the necessary parts Linear task: https://linear.app/comm/issue/ENG-5975/introduce-new-member-list-section Confirmed that the chat member list sidebar can open + close (will introduce the logic for that in subsequent diffs)
Diff Detail
Event Timeline
Comment Actions It seems odd that the modals would use this context. Can you give an example of how a modal will use it? Comment Actions The implementation of MemberListSidebarProvider looks correct and makes sense for now. That said, wonder if it would make sense to introduce some sort of higher level abstraction that's less MemberListSidebar specific. Similar to ModalContext, we could have something like PanelContext that could support multiple things being displayed in the sidebar, handle collapsing/displaying panels on the left, etc. Not sure if such scenarios exist in the designs, but seems like it'd be more flexible. Not necessary for now, but might be worth considering if we start introducing more sidebars. Comment Actions
With user profiles we can navigate to our chat with that user. When we do this, we should use the context to close the members sidebar Comment Actions
Atm no such scenarios outside of the members list exist, but yea I totally agree, if we ever create new features that utilize a sidebar like this introducing a more generic PanelContext would make sense. Going to land this diff for now since this feels outside the scope of what I have set, but will keep this in mind for when we next implement another panel sidebar and probably want to reuse a lot of this logic then. Comment Actions
I see, thank you! | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||