Page MenuHomePhabricator
Differential D10945

[identity] [shared] Separate identity search messages into client and server messages
ClosedPublic
Actions

Authored by will on Feb 5 2024, 7:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 2:45 PM
Unknown Object (File)
Thu, Mar 13, 4:11 PM
Unknown Object (File)
Mon, Mar 3, 6:22 AM
Unknown Object (File)
Sun, Mar 2, 10:45 PM
Unknown Object (File)
Sat, Mar 1, 6:11 PM
Unknown Object (File)
Feb 19 2025, 8:01 PM
Unknown Object (File)
Feb 19 2025, 4:21 PM
Unknown Object (File)
Feb 16 2025, 12:00 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMc79b20fa5646: [identity] [shared] Separate identity search messages into client and server…
Summary

This separates client and server messages into two different enums for organization purposes. This will be reflected in the client javascript flow types for proper runtime checking.

Depends on D10981

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Feb 5 2024, 7:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 5 2024, 7:40 AM
will retitled this revision from [identity] [shared] Separate identity search messages into client and server messages to [identity] [shared] [1/n] Separate identity search messages into client and server messages.Feb 5 2024, 7:42 AM
Harbormaster completed remote builds in B26498: Diff 36628.Feb 5 2024, 8:00 AM
will requested review of this revision.Feb 5 2024, 8:00 AM
will planned changes to this revision.Feb 5 2024, 11:38 AM
will edited the summary of this revision. (Show Details)Feb 6 2024, 11:34 PM
will added a parent revision: D10981: [shared] [identity] Move search result to response and add ids.
will retitled this revision from [identity] [shared] [1/n] Separate identity search messages into client and server messages to [identity] [shared] [3/n] Separate identity search messages into client and server messages.
will updated this revision to Diff 36780.Feb 7 2024, 7:19 AM

rebase

Harbormaster completed remote builds in B26619: Diff 36780.Feb 7 2024, 7:35 AM
will retitled this revision from [identity] [shared] [3/n] Separate identity search messages into client and server messages to [identity] [shared] Separate identity search messages into client and server messages.Feb 8 2024, 10:13 AM
will updated this revision to Diff 36867.Feb 8 2024, 10:17 AM

rebase

will added a child revision: D10996: [identity] Remove usage of sending raw error messages to client.Feb 8 2024, 10:20 AM
Harbormaster failed remote builds in B26659: Diff 36867!Feb 8 2024, 10:22 AM
will mentioned this in D10928: [lib] Add types for identity search websocket server.Feb 8 2024, 11:48 AM
will updated this revision to Diff 37014.Feb 13 2024, 12:31 AM

rebase

Harbormaster completed remote builds in B26774: Diff 37014.Feb 13 2024, 12:49 AM
varun accepted this revision.Feb 13 2024, 11:21 AM
varun added inline comments.
shared/identity_search_messages/src/messages/mod.rs
2 ↗(On Diff #37014)

can we add a note here like we did in D10928 to make sure this file stays in sync with lib/types/identity-search/messages.js?

This revision is now accepted and ready to land.Feb 13 2024, 11:21 AM
will updated this revision to Diff 37277.Feb 15 2024, 12:35 PM

rebase

Harbormaster completed remote builds in B26936: Diff 37277.Feb 15 2024, 12:54 PM
will updated this revision to Diff 37364.Feb 20 2024, 7:08 AM

rebase

Harbormaster completed remote builds in B27003: Diff 37364.Feb 20 2024, 7:22 AM
will updated this revision to Diff 37617.Feb 26 2024, 11:21 AM

cargo fmt

Harbormaster failed remote builds in B27184: Diff 37617!Feb 26 2024, 11:28 AM
will updated this revision to Diff 37618.Feb 26 2024, 12:33 PM

rebase

This revision was landed with ongoing or failed builds.Feb 26 2024, 12:45 PM
Closed by commit rCOMMc79b20fa5646: [identity] [shared] Separate identity search messages into client and server… (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMc79b20fa5646: [identity] [shared] Separate identity search messages into client and server….
Harbormaster completed remote builds in B27185: Diff 37618.Feb 26 2024, 12:48 PM
Harbormaster completed remote builds in B27184: Diff 37617.Feb 26 2024, 4:01 PM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
9 lines
shared/
identity_search_messages/
src/
messages/
14 lines

Diff 37619

View Options

services/identity/src/websockets/mod.rs

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

shared/identity_search_messages/src/messages/mod.rs

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines