Page MenuHomePhabricator
Differential D10980

[identity] [shared] Change search query enum to struct and introduce search method enum
ClosedPublic
Actions

Authored by will on Feb 6 2024, 11:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Jan 13 2025, 5:52 PM
Unknown Object (File)
Jan 13 2025, 4:12 PM
View All 92 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM0716c6a8cb8f: [identity] [shared] Change search query enum to struct and introduce search…
Summary

This introduces the search method which includes search types like Prefix. The search query contains the search method but will also be extended to include a query request id for future work on the identity search context handler.

Depends on D11096

Test Plan

cargo build and testing on local dev

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Feb 6 2024, 11:22 PM
will held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 6 2024, 11:22 PM
will retitled this revision from [identity] [shared] Change search query enum to struct and introduce search method enum to [identity] [shared] [1/n] Change search query enum to struct and introduce search method enum.Feb 6 2024, 11:29 PM
will added a child revision: D10981: [shared] [identity] Move search result to response and add ids.
will published this revision for review.Feb 6 2024, 11:31 PM
Harbormaster completed remote builds in B26607: Diff 36764.Feb 6 2024, 11:39 PM
bartek accepted this revision.Feb 7 2024, 1:15 AM
This revision is now accepted and ready to land.Feb 7 2024, 1:15 AM
will retitled this revision from [identity] [shared] [1/n] Change search query enum to struct and introduce search method enum to [identity] [shared] Change search query enum to struct and introduce search method enum.Feb 8 2024, 10:13 AM
will edited the summary of this revision. (Show Details)Feb 15 2024, 12:30 PM
will added a parent revision: D11096: [shared] [identity] Prepend "IdentitySearch" to identity search struct/enum names.
will updated this revision to Diff 37275.Feb 15 2024, 12:31 PM

rebase

Harbormaster failed remote builds in B26934: Diff 37275!Feb 15 2024, 12:38 PM
will planned changes to this revision.Feb 15 2024, 8:38 PM
will updated this revision to Diff 37360.Feb 20 2024, 7:02 AM

rebase with IdentitySearch prefix

This revision is now accepted and ready to land.Feb 20 2024, 7:02 AM
Harbormaster completed remote builds in B27000: Diff 37360.Feb 20 2024, 7:16 AM
Closed by commit rCOMM0716c6a8cb8f: [identity] [shared] Change search query enum to struct and introduce search… (authored by will). · Explain WhyFeb 26 2024, 6:29 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM0716c6a8cb8f: [identity] [shared] Change search query enum to struct and introduce search….
will removed a child revision: D10981: [shared] [identity] Move search result to response and add ids.Feb 26 2024, 7:29 AM
will added a child revision: D10981: [shared] [identity] Move search result to response and add ids.Feb 26 2024, 10:47 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
6 lines
shared/
identity_search_messages/
src/
messages/
8 lines

Diff 37608

View Options

services/identity/src/websockets/mod.rs

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

shared/identity_search_messages/src/messages/search_query.rs

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines