Paths

Table of Contentst

Differential D10981

[shared] [identity] Move search result to response and add ids
ClosedPublic
Actions

Authored by will on Feb 6 2024, 11:26 PM.

Tags

None

Referenced Files

	F3248318: D10981.id37616.diff
	Fri, Nov 15, 9:20 AM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

Subscribers

Details

Reviewers

bartek
varun

Commits

rCOMM5ed0b0531a0b: [shared] [identity] Move search result to response and add ids

Summary

These changes prepare the context handler to resolve search query promises.

This introduces ids to search queries and responses and introduces the search response type which is now composed a successful search result or an error. The ids are used to match queries to responses in the client.

Further explanation: https://linear.app/comm/issue/ENG-5505/implement-contextprovider-pattern-for-web-socket-connection-status#comment-2162a512

Depends on D10980

Test Plan

cargo build and test on local dev

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Feb 6 2024, 11:26 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 6 2024, 11:26 PM

will retitled this revision from [shared] [identity] Move search result to response and add ids to [shared] [identity] [2/n] Move search result to response and add ids.Feb 6 2024, 11:29 PM

will edited the summary of this revision. (Show Details)

will added a parent revision: D10980: [identity] [shared] Change search query enum to struct and introduce search method enum.

will published this revision for review.Feb 6 2024, 11:31 PM

will added a child revision: D10945: [identity] [shared] Separate identity search messages into client and server messages.Feb 6 2024, 11:34 PM

will added a child revision: D10928: [lib] Add types for identity search websocket server.Feb 6 2024, 11:37 PM

Harbormaster completed remote builds in B26608: Diff 36765.Feb 6 2024, 11:45 PM

will retitled this revision from [shared] [identity] [2/n] Move search result to response and add ids to [shared] [identity] Move search result to response and add ids.Feb 8 2024, 10:13 AM

will edited the summary of this revision. (Show Details)Feb 13 2024, 11:06 AM

looks good! just one question inline

shared/identity_search_messages/src/messages/search_response.rs
5 ↗	(On Diff #36765)	why do we derive all these things for `Failure` but not for `SearchResult`? do we actually need to derive these?

This revision is now accepted and ready to land.Feb 13 2024, 11:16 AM

will added inline comments.Feb 15 2024, 11:03 AM

shared/identity_search_messages/src/messages/search_response.rs
5 ↗	(On Diff #36765)	You're exactly right. Removing now

rebase

Harbormaster completed remote builds in B26935: Diff 37276.Feb 15 2024, 12:49 PM

rebase with IdentitySearch prefix

Harbormaster completed remote builds in B27001: Diff 37361.Feb 20 2024, 7:19 AM

will removed a child revision: D10928: [lib] Add types for identity search websocket server.Feb 25 2024, 2:11 PM

rebase

rebase

Harbormaster failed remote builds in B27150: Diff 37569!Feb 25 2024, 7:26 PM

Harbormaster failed remote builds in B27151: Diff 37570!Feb 26 2024, 4:48 AM

rebase

Harbormaster failed remote builds in B27180: Diff 37612!Feb 26 2024, 7:24 AM

will removed a parent revision: D10980: [identity] [shared] Change search query enum to struct and introduce search method enum.Feb 26 2024, 7:29 AM

rust fmt

Harbormaster failed remote builds in B27182: Diff 37614!Feb 26 2024, 10:54 AM

rebase

Harbormaster failed remote builds in B27183: Diff 37615!Feb 26 2024, 11:14 AM

This revision was landed with ongoing or failed builds.Feb 26 2024, 11:19 AM

Closed by commit rCOMM5ed0b0531a0b: [shared] [identity] Move search result to response and add ids (authored by will). · Explain Why

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM5ed0b0531a0b: [shared] [identity] Move search result to response and add ids.

Harbormaster completed remote builds in B27150: Diff 37569.Feb 26 2024, 2:58 PM

Harbormaster completed remote builds in B27151: Diff 37570.Feb 26 2024, 3:03 PM

Harbormaster completed remote builds in B27180: Diff 37612.Feb 26 2024, 3:54 PM

Harbormaster completed remote builds in B27182: Diff 37614.Feb 26 2024, 3:57 PM

Harbormaster completed remote builds in B27183: Diff 37615.Feb 26 2024, 3:59 PM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

websockets/

42 lines

shared/

identity_search_messages/

src/

messages/

6 lines

search_query.rs

1 line

	search_response.rs
	search_result.rs

15 lines

search_result.rs

Diff 37616

services/identity/src/websockets/mod.rs

Loading...

shared/identity_search_messages/src/messages/mod.rs

Loading...

shared/identity_search_messages/src/messages/search_query.rs

Loading...

shared/identity_search_messages/src/messages/search_response.rs

Loading...

shared/identity_search_messages/src/messages/search_result.rs

Loading...