Page MenuHomePhabricator

[backup] Move authentication inside of the websocket
ClosedPublic

Authored by michal on Feb 12 2024, 7:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 11:53 PM
Unknown Object (File)
Mon, Dec 23, 11:53 PM
Unknown Object (File)
Mon, Dec 23, 11:53 PM
Unknown Object (File)
Mon, Dec 23, 11:53 PM
Unknown Object (File)
Mon, Dec 23, 11:53 PM
Unknown Object (File)
Fri, Dec 13, 12:51 AM
Unknown Object (File)
Nov 26 2024, 11:37 AM
Unknown Object (File)
Nov 6 2024, 5:43 PM
Subscribers

Details

Summary

Unfortunately non-native web websockets (neither in JS nor in Rust compiled to WASM) allow us to attach additional headers to the first HTTP requests that starts the websocket. Because of that we need to migrate to another approach -> client must first send an authorization message.

Depends on D11038

Test Plan

Run backup integration tests.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil added 1 blocking reviewer(s): bartek.
This revision is now accepted and ready to land.Feb 13 2024, 5:14 AM