Details

Reviewers

bartek
kamil
marcin

Commits

rCOMMb68a0ed98658: [comm lib] Add additional features

Summary

Prerequisite for compiling backup client to WASM.

Move grpc client under a feature
Add a new web feature for all future wasm-related changes. For now this just adds a js feature to the uuid crate

Depends on D11039

Test Plan

Check if all rust crates compiled.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Feb 12 2024, 3:12 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 12 2024, 3:12 PM

michal added a child revision: D11041: [backup-client] Compile to wasm.Feb 12 2024, 3:18 PM

Harbormaster completed remote builds in B26760: Diff 36999.Feb 12 2024, 3:30 PM

michal requested review of this revision.Feb 12 2024, 3:30 PM

marcin resigned from this revision.Feb 13 2024, 7:55 AM

kamil accepted this revision.Feb 13 2024, 10:15 AM

This revision is now accepted and ready to land.Feb 13 2024, 10:15 AM

Missed lock for the native library

Harbormaster completed remote builds in B26785: Diff 37025.Feb 13 2024, 12:10 PM

Rebase

Update lock file

Harbormaster completed remote builds in B27101: Diff 37497.Feb 23 2024, 11:56 AM

Harbormaster completed remote builds in B27103: Diff 37499.Feb 23 2024, 12:09 PM

Rebase

Fix rebase error

Harbormaster failed remote builds in B27120: Diff 37536!Feb 23 2024, 5:19 PM

Harbormaster failed remote builds in B27121: Diff 37537!

Rebase

Harbormaster failed remote builds in B27123: Diff 37540!Feb 23 2024, 5:34 PM

Harbormaster failed remote builds in B27125: Diff 37542!Feb 23 2024, 5:38 PM

This revision was landed with ongoing or failed builds.Feb 26 2024, 1:07 PM

Closed by commit rCOMMb68a0ed98658: [comm lib] Add additional features. · Explain Why

This revision was automatically updated to reflect the committed changes.

Restricted Repository Identity added a commit: rCOMMb68a0ed98658: [comm lib] Add additional features.

Harbormaster completed remote builds in B27120: Diff 37536.Feb 26 2024, 10:02 PM

Harbormaster completed remote builds in B27121: Diff 37537.Feb 26 2024, 10:07 PM

Harbormaster completed remote builds in B27123: Diff 37540.

Harbormaster completed remote builds in B27125: Diff 37542.Feb 26 2024, 10:12 PM

[comm lib] Add additional features
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 37595

native/native_rust_library/Cargo.lock

services/backup/Cargo.lock

services/backup/Cargo.toml

services/blob/Cargo.lock

services/blob/Cargo.toml

services/commtest/Cargo.lock

services/feature-flags/Cargo.toml

services/identity/Cargo.toml

services/reports/Cargo.lock

services/reports/Cargo.toml

services/tunnelbroker/Cargo.toml

shared/backup_client/Cargo.lock

shared/comm-lib/Cargo.lock

shared/comm-lib/Cargo.toml

[comm lib] Add additional featuresClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37595

native/native_rust_library/Cargo.lock

services/backup/Cargo.lock

services/backup/Cargo.toml

services/blob/Cargo.lock

services/blob/Cargo.toml

services/commtest/Cargo.lock

services/feature-flags/Cargo.toml

services/identity/Cargo.toml

services/reports/Cargo.lock

services/reports/Cargo.toml

services/tunnelbroker/Cargo.toml

shared/backup_client/Cargo.lock

shared/comm-lib/Cargo.lock

shared/comm-lib/Cargo.toml

[comm lib] Add additional features
ClosedPublic
Actions

Revision Contents
Changeset List