Page MenuHomePhabricator
Differential D11101

[services] tidy up our identity service code
ClosedPublic
Actions

Authored by varun on Feb 15 2024, 9:37 PM.
Tags
None
Referenced Files
F5774546: D11101.id37293.diff
Tue, Apr 15, 12:45 AM
F5772108: D11101.id.diff
Mon, Apr 14, 9:55 PM
Unknown Object (File)
Mon, Apr 14, 5:03 AM
Unknown Object (File)
Sun, Mar 30, 2:56 PM
Unknown Object (File)
Thu, Mar 27, 6:32 PM
Unknown Object (File)
Sun, Mar 23, 3:41 AM
Unknown Object (File)
Thu, Mar 20, 8:17 AM
Unknown Object (File)
Mar 14 2025, 4:58 AM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
will
michal
Commits
rCOMM821dd280067d: [services] tidy up our identity service code
Summary

fix all the cargo clippy issues

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
2 lines
database/
1 line
16 lines
websockets/
4 lines
6 lines
shared/
tunnelbroker_messages/
src/
1 line

Diff 37473

View Options

services/identity/src/config.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import { decryptBase64, fetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
Show All 10 Lines
function EncryptedImage(props: Props): React.Node { function EncryptedImage(props: Props): React.Node {
const { const {
blobURI, blobURI,
encryptionKey, encryptionKey,
onLoad: onLoadProp, onLoad: onLoadProp,
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(ashoatKeyserverID)); const connection = useSelector(connectionSelector(ashoatKeyserverID));
invariant(connection, 'keyserver missing from keyserverStore'); invariant(connection, 'keyserver missing from keyserverStore');
const connectionStatus = connection.status; const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus); const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines const loadDecrypted = async () => {
} }
}; };
void loadDecrypted(); void loadDecrypted();
return () => { return () => {
isMounted = false; isMounted = false;
}; };
}, [attempt, blobURI, encryptionKey, mediaCache]); }, [attempt, blobURI, encryptionKey, mediaCache, fetchAndDecryptMedia]);
const onLoad = React.useCallback(() => { const onLoad = React.useCallback(() => {
onLoadProp && onLoadProp(blobURI); onLoadProp && onLoadProp(blobURI);
}, [blobURI, onLoadProp]); }, [blobURI, onLoadProp]);
const { style, spinnerColor, invisibleLoad } = props; const { style, spinnerColor, invisibleLoad } = props;
return ( return (
Show All 14 Lines
View Options

services/identity/src/database/device_list.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import { decryptBase64, fetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
Show All 10 Lines
function EncryptedImage(props: Props): React.Node { function EncryptedImage(props: Props): React.Node {
const { const {
blobURI, blobURI,
encryptionKey, encryptionKey,
onLoad: onLoadProp, onLoad: onLoadProp,
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(ashoatKeyserverID)); const connection = useSelector(connectionSelector(ashoatKeyserverID));
invariant(connection, 'keyserver missing from keyserverStore'); invariant(connection, 'keyserver missing from keyserverStore');
const connectionStatus = connection.status; const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus); const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines const loadDecrypted = async () => {
} }
}; };
void loadDecrypted(); void loadDecrypted();
return () => { return () => {
isMounted = false; isMounted = false;
}; };
}, [attempt, blobURI, encryptionKey, mediaCache]); }, [attempt, blobURI, encryptionKey, mediaCache, fetchAndDecryptMedia]);
const onLoad = React.useCallback(() => { const onLoad = React.useCallback(() => {
onLoadProp && onLoadProp(blobURI); onLoadProp && onLoadProp(blobURI);
}, [blobURI, onLoadProp]); }, [blobURI, onLoadProp]);
const { style, spinnerColor, invisibleLoad } = props; const { style, spinnerColor, invisibleLoad } = props;
return ( return (
Show All 14 Lines
View Options

services/identity/src/token.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import { decryptBase64, fetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
Show All 10 Lines
function EncryptedImage(props: Props): React.Node { function EncryptedImage(props: Props): React.Node {
const { const {
blobURI, blobURI,
encryptionKey, encryptionKey,
onLoad: onLoadProp, onLoad: onLoadProp,
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(ashoatKeyserverID)); const connection = useSelector(connectionSelector(ashoatKeyserverID));
invariant(connection, 'keyserver missing from keyserverStore'); invariant(connection, 'keyserver missing from keyserverStore');
const connectionStatus = connection.status; const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus); const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines const loadDecrypted = async () => {
} }
}; };
void loadDecrypted(); void loadDecrypted();
return () => { return () => {
isMounted = false; isMounted = false;
}; };
}, [attempt, blobURI, encryptionKey, mediaCache]); }, [attempt, blobURI, encryptionKey, mediaCache, fetchAndDecryptMedia]);
const onLoad = React.useCallback(() => { const onLoad = React.useCallback(() => {
onLoadProp && onLoadProp(blobURI); onLoadProp && onLoadProp(blobURI);
}, [blobURI, onLoadProp]); }, [blobURI, onLoadProp]);
const { style, spinnerColor, invisibleLoad } = props; const { style, spinnerColor, invisibleLoad } = props;
return ( return (
Show All 14 Lines
View Options

services/identity/src/websockets/errors.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheContext } from 'lib/components/media-cache-provider.react.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import { decryptBase64, fetchAndDecryptMedia } from './encryption-utils.js'; import { decryptBase64, useFetchAndDecryptMedia } from './encryption-utils.js';
import LoadableImage from './loadable-image.react.js'; import LoadableImage from './loadable-image.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { ImageSource } from '../types/react-native.js'; import type { ImageSource } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
type BaseProps = { type BaseProps = {
+blobURI: string, +blobURI: string,
+encryptionKey: string, +encryptionKey: string,
Show All 10 Lines
function EncryptedImage(props: Props): React.Node { function EncryptedImage(props: Props): React.Node {
const { const {
blobURI, blobURI,
encryptionKey, encryptionKey,
onLoad: onLoadProp, onLoad: onLoadProp,
thumbHash: encryptedThumbHash, thumbHash: encryptedThumbHash,
} = props; } = props;
const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connection = useSelector(connectionSelector(ashoatKeyserverID)); const connection = useSelector(connectionSelector(ashoatKeyserverID));
invariant(connection, 'keyserver missing from keyserverStore'); invariant(connection, 'keyserver missing from keyserverStore');
const connectionStatus = connection.status; const connectionStatus = connection.status;
const prevConnectionStatusRef = React.useRef(connectionStatus); const prevConnectionStatusRef = React.useRef(connectionStatus);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines const loadDecrypted = async () => {
} }
}; };
void loadDecrypted(); void loadDecrypted();
return () => { return () => {
isMounted = false; isMounted = false;
}; };
}, [attempt, blobURI, encryptionKey, mediaCache]); }, [attempt, blobURI, encryptionKey, mediaCache, fetchAndDecryptMedia]);
const onLoad = React.useCallback(() => { const onLoad = React.useCallback(() => {
onLoadProp && onLoadProp(blobURI); onLoadProp && onLoadProp(blobURI);
}, [blobURI, onLoadProp]); }, [blobURI, onLoadProp]);
const { style, spinnerColor, invisibleLoad } = props; const { style, spinnerColor, invisibleLoad } = props;
return ( return (
Show All 14 Lines
View Options

services/identity/src/websockets/mod.rs

Loading...
View Options

shared/tunnelbroker_messages/src/lib.rs

Loading...