Paths

Table of Contentst

Differential D11102

Add an ESLint rule that check filename format
ClosedPublic
Actions

Authored by tomek on Feb 16 2024, 1:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 25, 8:08 PM

	Unknown Object (File)
	Thu, Jun 20, 1:18 AM

	Unknown Object (File)
	Sat, Jun 15, 6:57 PM

	Unknown Object (File)
	Tue, Jun 11, 5:49 PM

	Unknown Object (File)
	Tue, Jun 11, 10:06 AM

	Unknown Object (File)
	Tue, Jun 11, 10:06 AM

	Unknown Object (File)
	Tue, Jun 11, 10:06 AM

	Unknown Object (File)
	Tue, Jun 11, 10:06 AM

View All 30 Files

Subscribers

Details

Reviewers

inka
kamil
atul
ashoat

Commits

rCOMM139f31894526: Add an ESLint rule that check filename format

Summary

Add a rule that enforces kebab-case names. Renamed the files using IDE so that all the references were updated.

The rule is from https://github.com/sindresorhus/eslint-plugin-unicorn/tree/main library - MIT license, 3.8k stars on GitHub.

https://linear.app/comm/issue/ENG-6819/make-sure-js-file-names-are-consistent

Test Plan

ESLint, Flow. Also checked if the web app can run.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 16 2024, 1:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 16 2024, 1:46 AM

tomek edited the summary of this revision. (Show Details)Feb 16 2024, 1:48 AM

tomek added inline comments.Feb 16 2024, 1:51 AM

.eslintrc.json
73 ↗	(On Diff #37295)	We're ignoring two patterns: The files with `flow-typed` definitions. These are suffixed with a version pattern which we check here. CodeGen schemas - updating these would result in different JSI class names.
lib/components/connected-wallet-info.react.js
8 ↗	(On Diff #37295)	Decided to go with this instead of `sw-mansion...` because we already have `swmansion-icon-config.json` file.

Add missing package.json and lock changes

Harbormaster completed remote builds in B26952: Diff 37295.Feb 16 2024, 2:01 AM

Harbormaster completed remote builds in B26953: Diff 37296.Feb 16 2024, 2:12 AM

tomek requested review of this revision.Feb 16 2024, 2:12 AM

tomek added a reviewer: ashoat.Feb 16 2024, 5:10 AM

Thank you for not just fixing the issue with the recent diff, but all of the issues in the codebase! This ESLint plugin looks great

This revision is now accepted and ready to land.Feb 16 2024, 7:29 AM

Rebase

Harbormaster completed remote builds in B26958: Diff 37315.Feb 19 2024, 1:53 AM

Closed by commit rCOMM139f31894526: Add an ESLint rule that check filename format (authored by tomek). · Explain WhyFeb 19 2024, 3:25 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM139f31894526: Add an ESLint rule that check filename format.

Revision Contents
Changeset List

Path

Size

12 lines

.lintstagedrc.js

4 lines

keyserver/

src/

cron/

2 lines

database/

migration-config.js

2 lines

responders/

website-responders.js

2 lines

utils/

	synchronize-invite-links-with-blobs.js
	synchronizeInviteLinksWithBlobs.js

synchronizeInviteLinksWithBlobs.js

landing/

Picture.react.js

2 lines

	picture.react.js
	Picture.react.js

lib/

components/

SWMansionIcon.react.js

connected-wallet-info.react.js

2 lines

	swmansion-icon.react.js
	SWMansionIcon.react.js

native/

codegen/

src/

	code-gen.js
	CodeGen.js

2 lines

1 line

scripts/

	get-cargo-path.js
	get_cargo_path.js

	get-clang-paths-cli.js
	get_clang_paths_cli.js

2 lines

	get-clang-paths.js
	get_clang_paths.js

get_cargo_path.js

get_clang_paths.js

get_clang_paths_cli.js

web/

CommIcon.react.js

account/

password-input.react.js

2 lines

siwe-login-form.react.js

2 lines

app-list/

app-list-item.react.js

2 lines

avatars/

edit-thread-avatar-menu.react.js

2 lines

edit-user-avatar-menu.react.js

4 lines

emoji-avatar-selection-modal.react.js

2 lines

calendar/

calendar.react.js

2 lines

chat/

chat-input-bar.react.js

2 lines

chat-thread-composer.react.js

2 lines

chat-thread-list-item-menu.react.js

2 lines

chat-thread-list-item.react.js

2 lines

composed-message.react.js

2 lines

inline-engagement.react.js

2 lines

member-list-sidebar/

member-list-sidebar-header.react.js

2 lines

thread-menu.react.js

2 lines

thread-top-bar.react.js

2 lines

	comm-icon.react.js
	CommIcon.react.js

community-header/

community-header-button.react.js

2 lines

components/

add-button.react.js

2 lines

clear-search-button.react.js

2 lines

community-actions-menu.react.js

2 lines

dropdown.react.js

2 lines

enum-settings-option-info.react.js

2 lines

keyserver-pill.react.js

2 lines

2 lines

menu-item.react.js

2 lines

navigation-arrows.react.js

2 lines

search.react.js

2 lines

invite-links/

copy-invite-link-button.react.js

2 lines

modals/

apps/

app-listing.react.js

2 lines

2 lines

threads/

create/

steps/

subchannel-settings.react.js

4 lines

members/

change-member-role-modal.react.js

2 lines

member.react.js

4 lines

settings/

thread-settings-delete-tab.react.js

2 lines

thread-settings-privacy-tab.react.js

2 lines

user-profile/

user-profile-menu.react.js

2 lines

user-profile-message-button.react.js

2 lines

user-profile.react.js

2 lines

navigation-panels/

app-switcher.react.js

2 lines

topbar.react.js

2 lines

navigation-sidebar/

account-settings-button.react.js

2 lines

community-creation-button.react.js

2 lines

navigation-sidebar-home-button.react.js

2 lines

push-notif/

badge-handler.react.js

2 lines

roles/

role-actions-menu.react.js

2 lines

role-panel-entry.react.js

2 lines

settings/

account-delete-modal.react.js

2 lines

account-settings.react.js

2 lines

relationship/

block-list-row.react.js

2 lines

friend-list-row.react.js

2 lines

sidebar/

community-creation/

community-creation-modal.react.js

2 lines

community-picker.react.js

2 lines

title/

	get-title.js
	getTitle.js

tooltips/

tooltip-action-utils.js

2 lines

142 lines

Diff 37318

.eslintrc.json

Loading...

.lintstagedrc.js

Loading...

keyserver/src/cron/cron.js

Loading...

keyserver/src/database/migration-config.js

Loading...

keyserver/src/responders/website-responders.js

Loading...

keyserver/src/utils/synchronize-invite-links-with-blobs.js

Loading...

keyserver/src/utils/synchronizeInviteLinksWithBlobs.js

Loading...

landing/Picture.react.js

Loading...

landing/hero.react.js

Loading...

landing/picture.react.js

Loading...

lib/components/SWMansionIcon.react.js

Loading...

lib/components/connected-wallet-info.react.js

Loading...

lib/components/swmansion-icon.react.js

Loading...

native/codegen/src/CodeGen.js

Loading...

native/codegen/src/code-gen.js

Loading...

native/codegen/src/index.js

Loading...

package.json

Loading...

scripts/get-cargo-path.js

Loading...

scripts/get-clang-paths-cli.js

Loading...

scripts/get-clang-paths.js

Loading...

scripts/get_cargo_path.js

Loading...

scripts/get_clang_paths.js

Loading...

scripts/get_clang_paths_cli.js

Loading...

web/CommIcon.react.js

Loading...

web/account/password-input.react.js

Loading...

web/account/siwe-login-form.react.js

Loading...

web/app-list/app-list-item.react.js

Loading...

web/avatars/edit-thread-avatar-menu.react.js

Loading...

web/avatars/edit-user-avatar-menu.react.js

Loading...

web/avatars/emoji-avatar-selection-modal.react.js

Loading...

web/calendar/calendar.react.js

Loading...

web/chat/chat-input-bar.react.js

Loading...

web/chat/chat-thread-composer.react.js

Loading...

web/chat/chat-thread-list-item-menu.react.js

Loading...

web/chat/chat-thread-list-item.react.js

Loading...

web/chat/composed-message.react.js

Loading...

web/chat/inline-engagement.react.js

Loading...

web/chat/member-list-sidebar/member-list-sidebar-header.react.js

Loading...

web/chat/thread-menu.react.js

Loading...

web/chat/thread-top-bar.react.js

Loading...

web/comm-icon.react.js

Loading...

web/community-header/community-header-button.react.js

Loading...

web/components/add-button.react.js

Loading...

web/components/clear-search-button.react.js

Loading...

web/components/community-actions-menu.react.js

Loading...

web/components/dropdown.react.js

Loading...

web/components/enum-settings-option-info.react.js

Loading...

web/components/keyserver-pill.react.js

Loading...

web/components/label.react.js

Loading...

web/components/menu-item.react.js

Loading...

web/components/navigation-arrows.react.js

Loading...

web/components/search.react.js

Loading...

web/invite-links/copy-invite-link-button.react.js

Loading...

web/modals/apps/app-listing.react.js

Loading...

web/modals/modal.react.js

Loading...

web/modals/threads/create/steps/subchannel-settings.react.js

Loading...

web/modals/threads/members/change-member-role-modal.react.js

Loading...

web/modals/threads/members/member.react.js

Loading...

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...

web/modals/user-profile/user-profile-menu.react.js

Loading...

web/modals/user-profile/user-profile-message-button.react.js

Loading...

web/modals/user-profile/user-profile.react.js

Loading...

web/navigation-panels/app-switcher.react.js

Loading...

web/navigation-panels/topbar.react.js

Loading...

web/navigation-sidebar/account-settings-button.react.js

Loading...

web/navigation-sidebar/community-creation-button.react.js

Loading...

web/navigation-sidebar/navigation-sidebar-home-button.react.js

Loading...

web/push-notif/badge-handler.react.js

Loading...

web/roles/role-actions-menu.react.js

Loading...

web/roles/role-panel-entry.react.js

Loading...

web/settings/account-delete-modal.react.js

Loading...

web/settings/account-settings.react.js

Loading...

web/settings/relationship/block-list-row.react.js

Loading...

web/settings/relationship/friend-list-row.react.js

Loading...

web/sidebar/community-creation/community-creation-modal.react.js

Loading...

web/sidebar/community-picker.react.js

Loading...

web/title/get-title.js

Loading...

web/title/getTitle.js

Loading...

web/tooltips/tooltip-action-utils.js

Loading...

yarn.lock

Loading...