Page MenuHomePhabricator
Differential D14481

[native] Remove ffmpeg dependency
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 7:23 PM
Unknown Object (File)
Fri, Apr 18, 6:16 AM
Unknown Object (File)
Thu, Apr 17, 12:18 PM
Unknown Object (File)
Thu, Apr 17, 11:43 AM
Unknown Object (File)
Thu, Apr 17, 5:11 AM
Unknown Object (File)
Mon, Apr 14, 5:16 PM
Unknown Object (File)
Mon, Apr 14, 1:20 AM
Unknown Object (File)
Thu, Apr 10, 4:02 PM
View All 49 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM2fb795a199b7: [native] Remove ffmpeg dependency
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

  • got rid of ffmpeg dependency
  • renamed ffmpeg.js to mediaProcessingQueue.js because the main feature of this file is the queue and wrapping functions from the media module
  • reanamed FFmpegStatistics and video_ffmpeg_transcode step

Depends on D14480

Test Plan

Compile the app and verify sending videos still work

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Mar 20 2025, 4:48 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 20 2025, 4:48 AM
Harbormaster completed remote builds in B33788: Diff 47492.Mar 20 2025, 5:22 AM
angelika edited the summary of this revision. (Show Details)Mar 20 2025, 5:41 AM
angelika updated this revision to Diff 47503.Mar 20 2025, 5:53 AM

Rebase

angelika published this revision for review.Mar 20 2025, 5:57 AM
Harbormaster completed remote builds in B33799: Diff 47503.Mar 20 2025, 6:11 AM
bartek accepted this revision.Mar 21 2025, 8:57 AM

Wondering how much smaller our binaries will be without ffmpeg 😀

This revision is now accepted and ready to land.Mar 21 2025, 8:57 AM
ashoat added inline comments.Mar 21 2025, 4:13 PM
native/media/media-processing-queue.js
31 ↗(On Diff #47503)

Do we still need this synchronous queue? We previously had it because of limitations in ffmpeg-kit, but it reduces performance when a user uploads multiple media in a single message

bartek added inline comments.Sun, Mar 23, 11:55 PM
native/media/media-processing-queue.js
31 ↗(On Diff #47503)

I was thinking about this too, but I have a suspicion that mobile devices can struggle with processing multiple videos simultaneously and CPU performance will be a limiting factor

angelika updated this revision to Diff 47557.Tue, Mar 25, 10:07 PM

Rebase

angelika added inline comments.Tue, Mar 25, 10:21 PM
native/media/media-processing-queue.js
31 ↗(On Diff #47503)

Tested it and:

  1. It's very slow
  2. Reporting progress currently works for one video at a time - we can implement progress for multiple videos (for example by adding video id to the progress event) but it's some additional work
Harbormaster completed remote builds in B33839: Diff 47557.Tue, Mar 25, 10:49 PM
Closed by commit rCOMM2fb795a199b7: [native] Remove ffmpeg dependency (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM2fb795a199b7: [native] Remove ffmpeg dependency.

Revision Contents
Changeset List

PathSize
lib/
types/
6 lines
native/
android/
4 lines
ios/
Comm.xcodeproj/
16 lines
1 line
12 lines
media/
4 lines
15 lines
11 lines
1 line
5 lines

Diff 47607

View Options

lib/types/media-types.js

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

native/android/build.gradle

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

native/ios/Podfile

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

native/ios/Podfile.lock

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

native/media/ffmpeg.js

Loading...
View Options

native/media/file-utils.js

Loading...
View Options

native/media/media-processing-queue.js

Loading...
View Options

native/media/video-utils.js

Loading...
View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...