Page MenuHomePhabricator
Differential D14469

[android] Implement getVideoInfo() function on Android
AcceptedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:32 AM.

Details

Reviewers
bartek
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14468

Test Plan

Try to send a video and see video info

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:32 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:32 AM
angelika added a child revision: D14470: [ios] Implement getVideoInfo() function on iOS.Thu, Mar 20, 4:33 AM
Harbormaster completed remote builds in B33776: Diff 47480.Thu, Mar 20, 4:50 AM
angelika added inline comments.Thu, Mar 20, 4:54 AM
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
68

I don't know what format is in the original ffmpeg implementation. It's not documented anywhere and when I've tested it the ffmpeg implementation didn't even return it. Because it's later compared to "mp4" to check if format is correct I'm just returning the file extension. We can run more complicated checks but I think it's good enough for our usecase.

angelika published this revision for review.Thu, Mar 20, 5:55 AM
bartek accepted this revision.Fri, Mar 21, 1:42 AM
bartek added inline comments.
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
68

I agree, let's keep it this way for now

This revision is now accepted and ready to land.Fri, Mar 21, 1:42 AM

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
media/
70 lines

Diff 47480

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

Loading...