Differential D14476

[ios] Implement generateThumbnail() function on iOS
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:42 AM.

Details

Reviewers

bartek

Commits

rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14475

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Mar 20 2025, 4:42 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 20 2025, 4:42 AM

angelika added a child revision: D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.Mar 20 2025, 4:43 AM

Harbormaster completed remote builds in B33783: Diff 47487.Mar 20 2025, 5:08 AM

angelika edited the summary of this revision. (Show Details)Mar 20 2025, 5:10 AM

angelika published this revision for review.Mar 20 2025, 5:56 AM

bartek accepted this revision.Mar 21 2025, 1:57 AM

This revision is now accepted and ready to land.Mar 21 2025, 1:57 AM

Rebase

Harbormaster completed remote builds in B33834: Diff 47552.Tue, Mar 25, 10:32 PM

Closed by commit rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

ios/

MediaModule.swift

35 lines

Diff 47602

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

This file was added.

				// @flow

				import reduceKeyserverStore from './keyserver-reducer.js';
				import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
				import { defaultKeyserverInfo } from '../types/keyserver-types.js';

				describe('reduceKeyserverStore', () => {
				it('removes from the store keyservers the user has disconnected from', () => {
				const oldKeyserverStore = {
				keyserverInfos: {
				['0']: defaultKeyserverInfo('url1'),
				['100']: defaultKeyserverInfo('url2'),
				['200']: defaultKeyserverInfo('url3'),
				},
				};

				const deleteAccountAction = {
				type: deleteKeyserverAccountActionTypes.success,
				payload: {
				currentUserInfo: { anonymous: true },
				preRequestUserState: {
				cookiesAndSessions: {},
				currentUserInfo: {
				id: '1000',
				username: 'test',
				},
				},
				keyserverIDs: ['100', '200'],
				},
				loadingInfo: {
				fetchIndex: 1,
				trackMultipleRequests: false,
				customKeyName: undefined,
				},
				};

				expect(
				reduceKeyserverStore(oldKeyserverStore, deleteAccountAction),
				).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
				});
				});

[ios] Implement generateThumbnail() function on iOSClosedPublicActions