Page MenuHomePhabricator
Differential D14472

[android] Implement hasMultipleFrames() function on Android
AcceptedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:38 AM.
Tags
None
Referenced Files
F5057497: D14472.diff
Wed, Mar 26, 12:13 AM
F5056192: D14472.diff
Tue, Mar 25, 9:10 PM
F5055882: D14472.diff
Tue, Mar 25, 6:03 PM
Unknown Object (File)
Tue, Mar 25, 6:41 AM
Unknown Object (File)
Tue, Mar 25, 5:31 AM
Unknown Object (File)
Mon, Mar 24, 2:31 PM
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14471

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:38 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:38 AM
angelika added a child revision: D14473: [ios] Implement hasMultipleFrames() function on iOS.Thu, Mar 20, 4:39 AM
Harbormaster completed remote builds in B33779: Diff 47483.Thu, Mar 20, 4:56 AM
angelika added inline comments.Thu, Mar 20, 5:05 AM
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91 ↗(On Diff #47483)

Movie is deprecated but AnimatedImageDrawable is available only for Android 9+. According to our build.gradle we're supporting Android 8.0+ so I put both versions and a check here.

angelika published this revision for review.Thu, Mar 20, 5:56 AM
bartek accepted this revision.Fri, Mar 21, 1:51 AM
bartek added inline comments.
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91 ↗(On Diff #47483)

👍

This revision is now accepted and ready to land.Fri, Mar 21, 1:51 AM
angelika updated this revision to Diff 47548.Tue, Mar 25, 10:02 PM

Rebase

Harbormaster completed remote builds in B33830: Diff 47548.Tue, Mar 25, 10:21 PM

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
media/
41 lines

Diff 47548

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

landing/dist landing/dist
landing/flow-typed landing/flow-typed
landing/node_modules landing/node_modules
lib/flow-typed lib/flow-typed
lib/node_modules lib/node_modules
web/dist web/dist
web/flow-typed web/flow-typed
web/node_modules web/node_modules
web/opaque-ke-wasm/pkg web/opaque-ke-wasm/pkg
web/database/_generated web/database/_generated
web/backup-client-wasm/wasm/backup-client-wasm.js
keyserver/app_compiled keyserver/app_compiled
keyserver/landing_compiled keyserver/landing_compiled
keyserver/dist keyserver/dist
keyserver/secrets keyserver/secrets
keyserver/facts keyserver/facts
keyserver/fonts keyserver/fonts
keyserver/flow-typed keyserver/flow-typed
keyserver/node_modules keyserver/node_modules
Show All 11 Lines