Page MenuHomePhabricator
Differential D14475

[android] Implement generateThumbnail() function on Android
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 13, 9:16 PM
Unknown Object (File)
Sun, Apr 13, 5:01 PM
Unknown Object (File)
Sun, Apr 13, 11:26 AM
Unknown Object (File)
Sat, Apr 12, 5:08 PM
Unknown Object (File)
Thu, Apr 10, 1:24 PM
Unknown Object (File)
Thu, Apr 10, 7:59 AM
Unknown Object (File)
Thu, Apr 10, 7:19 AM
Unknown Object (File)
Wed, Apr 9, 1:30 PM
View All 34 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14474

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
media/
36 lines

Diff 47601

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };