Page MenuHomePhabricator
Differential D14470

[ios] Implement getVideoInfo() function on iOS
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:33 AM.
Tags
None
Referenced Files
F5084764: D14470.id47546.diff
Sat, Mar 29, 2:42 PM
F5078355: D14470.id47546.diff
Sat, Mar 29, 1:58 AM
F5076526: D14470.id.diff
Fri, Mar 28, 7:56 PM
Unknown Object (File)
Thu, Mar 27, 7:55 PM
Unknown Object (File)
Wed, Mar 26, 8:11 PM
Unknown Object (File)
Wed, Mar 26, 11:05 AM
Unknown Object (File)
Wed, Mar 26, 9:48 AM
Unknown Object (File)
Tue, Mar 25, 10:13 PM
View All 14 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM7f1a59810cb8: [ios] Implement getVideoInfo() function on iOS
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14469

Test Plan

Try to send a video and see video info

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Thu, Mar 20, 4:33 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:33 AM
angelika added a child revision: D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.Thu, Mar 20, 4:34 AM
Harbormaster completed remote builds in B33777: Diff 47481.Thu, Mar 20, 4:51 AM
angelika added inline comments.Thu, Mar 20, 4:57 AM
native/expo-modules/comm-expo-package/ios/MediaModule.swift
4 ↗(On Diff #47481)

This is copied from the official apple docs: https://developer.apple.com/documentation/avfoundation/avassettrack/formatdescriptions#Discussion

71 ↗(On Diff #47481)

I don't know what format is in the original ffmpeg implementation. It's not documented anywhere and when I've tested it the ffmpeg implementation didn't even return it. Because it's later compared to "mp4" to check if format is correct I'm just returning the file extension. We can run more complicated checks but I think it's good enough for our usecase.

angelika published this revision for review.Thu, Mar 20, 5:55 AM
bartek added inline comments.Fri, Mar 21, 1:48 AM
native/expo-modules/comm-expo-package/ios/MediaModule.swift
63 ↗(On Diff #47481)

According to the docs link you posted above, isn't this way of accessing format descriptions deprecated?

bartek accepted this revision.Sun, Mar 23, 11:47 PM
This revision is now accepted and ready to land.Sun, Mar 23, 11:47 PM
angelika updated this revision to Diff 47546.Tue, Mar 25, 10:01 PM

Rebase

angelika added inline comments.Tue, Mar 25, 10:10 PM
native/expo-modules/comm-expo-package/ios/MediaModule.swift
63 ↗(On Diff #47481)

It is deprecated but the new way is available for ios 15+ and we're supporting ios 13+

Harbormaster failed remote builds in B33828: Diff 47546!Tue, Mar 25, 10:15 PM
This revision was landed with ongoing or failed builds.Thu, Mar 27, 12:21 PM
Closed by commit rCOMM7f1a59810cb8: [ios] Implement getVideoInfo() function on iOS (authored by angelika). · Explain Why
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM7f1a59810cb8: [ios] Implement getVideoInfo() function on iOS.

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
ios/
76 lines

Diff 47596

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines