Differential D14477

[native] Use generateThumbnail() from MediaModule instead of ffmpeg
AcceptedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:43 AM.

Tags

None

Referenced Files

	F4959739: D14477.diff
	Sun, Mar 23, 8:56 AM

	F4959172: D14477.id47488.diff
	Sun, Mar 23, 5:42 AM

	Unknown Object (File)
	Sun, Mar 23, 2:35 AM

	Unknown Object (File)
	Sat, Mar 22, 6:12 PM

	Unknown Object (File)
	Sat, Mar 22, 1:29 PM

Subscribers

Details

Reviewers

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

One small change is that we no longer have return code, but we can throw exceptions. I changed code accordingly.

Depends on D14476

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:43 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:43 AM

angelika added a child revision: D14478: [android] Implement transcodeVideo() function on Android.Thu, Mar 20, 4:45 AM

Harbormaster completed remote builds in B33784: Diff 47488.Thu, Mar 20, 5:07 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 5:11 AM

Fix

angelika published this revision for review.Thu, Mar 20, 5:57 AM

Harbormaster completed remote builds in B33796: Diff 47500.Thu, Mar 20, 6:07 AM

bartek accepted this revision.Fri, Mar 21, 2:00 AM

This revision is now accepted and ready to land.Fri, Mar 21, 2:00 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

2 lines

native/

media/

21 lines

15 lines

utils/

media-module.js

8 lines

Diff 47500

lib/types/media-types.js

	locals {			locals {
	identity_service_image_tag = local.is_staging ? "0.37" : "0.37"			identity_service_image_tag = local.is_staging ? "0.38" : "0.37"
	identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"			identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
	identity_service_container_name = "identity-server"			identity_service_container_name = "identity-server"

	# Port that the container is listening on			# Port that the container is listening on
	identity_service_container_grpc_port = 50054			identity_service_container_grpc_port = 50054
	identity_sc_port_name = "identity-service-ecs-grpc"			identity_sc_port_name = "identity-service-ecs-grpc"
	identity_sc_dns_name = "identity-service"			identity_sc_dns_name = "identity-service"

	▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines

native/media/ffmpeg.js

	locals {			locals {
	identity_service_image_tag = local.is_staging ? "0.37" : "0.37"			identity_service_image_tag = local.is_staging ? "0.38" : "0.37"
	identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"			identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
	identity_service_container_name = "identity-server"			identity_service_container_name = "identity-server"

	# Port that the container is listening on			# Port that the container is listening on
	identity_service_container_grpc_port = 50054			identity_service_container_grpc_port = 50054
	identity_sc_port_name = "identity-service-ecs-grpc"			identity_sc_port_name = "identity-service-ecs-grpc"
	identity_sc_dns_name = "identity-service"			identity_sc_dns_name = "identity-service"

	▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines

native/media/video-utils.js

	locals {			locals {
	identity_service_image_tag = local.is_staging ? "0.37" : "0.37"			identity_service_image_tag = local.is_staging ? "0.38" : "0.37"
	identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"			identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
	identity_service_container_name = "identity-server"			identity_service_container_name = "identity-server"

	# Port that the container is listening on			# Port that the container is listening on
	identity_service_container_grpc_port = 50054			identity_service_container_grpc_port = 50054
	identity_sc_port_name = "identity-service-ecs-grpc"			identity_sc_port_name = "identity-service-ecs-grpc"
	identity_sc_dns_name = "identity-service"			identity_sc_dns_name = "identity-service"

	▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines

native/utils/media-module.js

	locals {			locals {
	identity_service_image_tag = local.is_staging ? "0.37" : "0.37"			identity_service_image_tag = local.is_staging ? "0.38" : "0.37"
	identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"			identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
	identity_service_container_name = "identity-server"			identity_service_container_name = "identity-server"

	# Port that the container is listening on			# Port that the container is listening on
	identity_service_container_grpc_port = 50054			identity_service_container_grpc_port = 50054
	identity_sc_port_name = "identity-service-ecs-grpc"			identity_sc_port_name = "identity-service-ecs-grpc"
	identity_sc_dns_name = "identity-service"			identity_sc_dns_name = "identity-service"

	▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines