Page MenuHomePhabricator
Differential D14477

[native] Use generateThumbnail() from MediaModule instead of ffmpeg
AcceptedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:43 AM.
Tags
None
Referenced Files
F5059432: D14477.diff
Wed, Mar 26, 10:56 AM
F5056275: D14477.diff
Tue, Mar 25, 9:56 PM
F5056212: D14477.id47500.diff
Tue, Mar 25, 9:23 PM
F5055773: D14477.diff
Tue, Mar 25, 4:48 PM
F5055565: D14477.diff
Tue, Mar 25, 3:17 PM
Unknown Object (File)
Mon, Mar 24, 2:09 PM
Unknown Object (File)
Sun, Mar 23, 8:56 AM
Unknown Object (File)
Sun, Mar 23, 5:42 AM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

One small change is that we no longer have return code, but we can throw exceptions. I changed code accordingly.

Depends on D14476

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
media/
21 lines
15 lines
utils/
8 lines

Diff 47500

View Options

lib/types/media-types.js

  • This file was added.
.container {
display: flex;
column-gap: 8px;
align-items: center;
justify-content: center;
}
View Options

native/media/ffmpeg.js

  • This file was added.
.container {
display: flex;
column-gap: 8px;
align-items: center;
justify-content: center;
}
View Options

native/media/video-utils.js

  • This file was added.
.container {
display: flex;
column-gap: 8px;
align-items: center;
justify-content: center;
}
View Options

native/utils/media-module.js

  • This file was added.
.container {
display: flex;
column-gap: 8px;
align-items: center;
justify-content: center;
}