Page MenuHomePhabricator
Differential D14477

[native] Use generateThumbnail() from MediaModule instead of ffmpeg
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:43 AM.
Tags
None
Referenced Files
F6214685: D14477.id.diff
Thu, Apr 24, 1:21 AM
F6213071: D14477.diff
Thu, Apr 24, 12:19 AM
F6197835: D14477.diff
Wed, Apr 23, 4:00 PM
Unknown Object (File)
Wed, Apr 9, 11:05 PM
Unknown Object (File)
Wed, Apr 9, 6:00 PM
Unknown Object (File)
Wed, Apr 9, 4:48 PM
Unknown Object (File)
Wed, Apr 9, 1:03 PM
Unknown Object (File)
Wed, Apr 9, 11:38 AM
View All 43 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM822d231b91d0: [native] Use generateThumbnail() from MediaModule instead of ffmpeg
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

One small change is that we no longer have return code, but we can throw exceptions. I changed code accordingly.

Depends on D14476

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Mar 20 2025, 4:43 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 20 2025, 4:43 AM
angelika added a child revision: D14478: [android] Implement transcodeVideo() function on Android.Mar 20 2025, 4:45 AM
Harbormaster completed remote builds in B33784: Diff 47488.Mar 20 2025, 5:07 AM
angelika edited the summary of this revision. (Show Details)Mar 20 2025, 5:11 AM
angelika updated this revision to Diff 47500.Mar 20 2025, 5:48 AM

Fix

angelika published this revision for review.Mar 20 2025, 5:57 AM
Harbormaster completed remote builds in B33796: Diff 47500.Mar 20 2025, 6:07 AM
bartek accepted this revision.Mar 21 2025, 2:00 AM
This revision is now accepted and ready to land.Mar 21 2025, 2:00 AM
angelika updated this revision to Diff 47553.Tue, Mar 25, 10:04 PM

Rebase

Harbormaster completed remote builds in B33835: Diff 47553.Tue, Mar 25, 10:39 PM
Closed by commit rCOMM822d231b91d0: [native] Use generateThumbnail() from MediaModule instead of ffmpeg (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM822d231b91d0: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
media/
21 lines
15 lines
utils/
8 lines

Diff 47553

View Options

lib/types/media-types.js

Show All 12 Lines
type TextProps = React.ElementConfig<typeof Text>; type TextProps = React.ElementConfig<typeof Text>;
export type TextStyle = $PropertyType<TextProps, 'style'>; export type TextStyle = $PropertyType<TextProps, 'style'>;
type ImageProps = React.ElementConfig<typeof Image>; type ImageProps = React.ElementConfig<typeof Image>;
export type ImageStyle = $PropertyType<ImageProps, 'style'>; export type ImageStyle = $PropertyType<ImageProps, 'style'>;
export type AnimatedStyleObj = { export type AnimatedStyleObj = {
+opacity?: ?number | Animated.Node, +opacity?: ?number | Animated.Node,
+height?: ?number | Animated.Node,
+width?: ?number | Animated.Node, +width?: ?number | Animated.Node,
+marginTop?: ?number | Animated.Node,
+marginRight?: ?number | Animated.Node, +marginRight?: ?number | Animated.Node,
+marginLeft?: ?number | Animated.Node,
+backgroundColor?: ?string | Animated.Node,
+bottom?: ?number | Animated.Node,
+transform?: $ReadOnlyArray<{ +transform?: $ReadOnlyArray<{
+scale?: ?number | Animated.Node, +scale?: ?number | Animated.Node,
+translateX?: ?number | Animated.Node,
+translateY?: ?number | Animated.Node,
... ...
}>, }>,
... ...
}; };
export type AnimatedViewStyle = export type AnimatedViewStyle =
| AnimatedStyleObj | AnimatedStyleObj
| $ReadOnlyArray<ViewStyle | AnimatedStyleObj>; | $ReadOnlyArray<ViewStyle | AnimatedStyleObj>;
Show All 27 Lines
View Options

native/media/ffmpeg.js

Show All 12 Lines
type TextProps = React.ElementConfig<typeof Text>; type TextProps = React.ElementConfig<typeof Text>;
export type TextStyle = $PropertyType<TextProps, 'style'>; export type TextStyle = $PropertyType<TextProps, 'style'>;
type ImageProps = React.ElementConfig<typeof Image>; type ImageProps = React.ElementConfig<typeof Image>;
export type ImageStyle = $PropertyType<ImageProps, 'style'>; export type ImageStyle = $PropertyType<ImageProps, 'style'>;
export type AnimatedStyleObj = { export type AnimatedStyleObj = {
+opacity?: ?number | Animated.Node, +opacity?: ?number | Animated.Node,
+height?: ?number | Animated.Node,
+width?: ?number | Animated.Node, +width?: ?number | Animated.Node,
+marginTop?: ?number | Animated.Node,
+marginRight?: ?number | Animated.Node, +marginRight?: ?number | Animated.Node,
+marginLeft?: ?number | Animated.Node,
+backgroundColor?: ?string | Animated.Node,
+bottom?: ?number | Animated.Node,
+transform?: $ReadOnlyArray<{ +transform?: $ReadOnlyArray<{
+scale?: ?number | Animated.Node, +scale?: ?number | Animated.Node,
+translateX?: ?number | Animated.Node,
+translateY?: ?number | Animated.Node,
... ...
}>, }>,
... ...
}; };
export type AnimatedViewStyle = export type AnimatedViewStyle =
| AnimatedStyleObj | AnimatedStyleObj
| $ReadOnlyArray<ViewStyle | AnimatedStyleObj>; | $ReadOnlyArray<ViewStyle | AnimatedStyleObj>;
Show All 27 Lines
View Options

native/media/video-utils.js

Show All 12 Lines
type TextProps = React.ElementConfig<typeof Text>; type TextProps = React.ElementConfig<typeof Text>;
export type TextStyle = $PropertyType<TextProps, 'style'>; export type TextStyle = $PropertyType<TextProps, 'style'>;
type ImageProps = React.ElementConfig<typeof Image>; type ImageProps = React.ElementConfig<typeof Image>;
export type ImageStyle = $PropertyType<ImageProps, 'style'>; export type ImageStyle = $PropertyType<ImageProps, 'style'>;
export type AnimatedStyleObj = { export type AnimatedStyleObj = {
+opacity?: ?number | Animated.Node, +opacity?: ?number | Animated.Node,
+height?: ?number | Animated.Node,
+width?: ?number | Animated.Node, +width?: ?number | Animated.Node,
+marginTop?: ?number | Animated.Node,
+marginRight?: ?number | Animated.Node, +marginRight?: ?number | Animated.Node,
+marginLeft?: ?number | Animated.Node,
+backgroundColor?: ?string | Animated.Node,
+bottom?: ?number | Animated.Node,
+transform?: $ReadOnlyArray<{ +transform?: $ReadOnlyArray<{
+scale?: ?number | Animated.Node, +scale?: ?number | Animated.Node,
+translateX?: ?number | Animated.Node,
+translateY?: ?number | Animated.Node,
... ...
}>, }>,
... ...
}; };
export type AnimatedViewStyle = export type AnimatedViewStyle =
| AnimatedStyleObj | AnimatedStyleObj
| $ReadOnlyArray<ViewStyle | AnimatedStyleObj>; | $ReadOnlyArray<ViewStyle | AnimatedStyleObj>;
Show All 27 Lines
View Options

native/utils/media-module.js

Show All 12 Lines
type TextProps = React.ElementConfig<typeof Text>; type TextProps = React.ElementConfig<typeof Text>;
export type TextStyle = $PropertyType<TextProps, 'style'>; export type TextStyle = $PropertyType<TextProps, 'style'>;
type ImageProps = React.ElementConfig<typeof Image>; type ImageProps = React.ElementConfig<typeof Image>;
export type ImageStyle = $PropertyType<ImageProps, 'style'>; export type ImageStyle = $PropertyType<ImageProps, 'style'>;
export type AnimatedStyleObj = { export type AnimatedStyleObj = {
+opacity?: ?number | Animated.Node, +opacity?: ?number | Animated.Node,
+height?: ?number | Animated.Node,
+width?: ?number | Animated.Node, +width?: ?number | Animated.Node,
+marginTop?: ?number | Animated.Node,
+marginRight?: ?number | Animated.Node, +marginRight?: ?number | Animated.Node,
+marginLeft?: ?number | Animated.Node,
+backgroundColor?: ?string | Animated.Node,
+bottom?: ?number | Animated.Node,
+transform?: $ReadOnlyArray<{ +transform?: $ReadOnlyArray<{
+scale?: ?number | Animated.Node, +scale?: ?number | Animated.Node,
+translateX?: ?number | Animated.Node,
+translateY?: ?number | Animated.Node,
... ...
}>, }>,
... ...
}; };
export type AnimatedViewStyle = export type AnimatedViewStyle =
| AnimatedStyleObj | AnimatedStyleObj
| $ReadOnlyArray<ViewStyle | AnimatedStyleObj>; | $ReadOnlyArray<ViewStyle | AnimatedStyleObj>;
Show All 27 Lines