Page MenuHomePhabricator
Differential D14479

[ios] Implement transcodeVideo() function on iOS
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 6:12 PM
Unknown Object (File)
Sat, Apr 19, 2:51 PM
Unknown Object (File)
Fri, Apr 18, 8:17 AM
Unknown Object (File)
Mon, Apr 14, 1:12 AM
Unknown Object (File)
Thu, Apr 10, 10:50 PM
Unknown Object (File)
Thu, Apr 10, 10:36 PM
Unknown Object (File)
Wed, Apr 9, 9:34 PM
Unknown Object (File)
Wed, Apr 9, 8:55 PM
View All 42 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Changes:

  • on the native side we check progress every 200ms and send an event to the js side. The JS side then calls the callback with the progress
  • we can specify the profile and bitrate, we can't specify fps though
  • width and height is mandatory to keep it simple (ios requires it)
  • I'm returning some basic stats (speed, size and duration) but some are missing compared to ffmpeg implementation because I don't see much sense in collecting them. However I can add them if necessary (should be easy on Android, more complicated on iOS)

I'm using AVWriter instead of AVAssetExportSession. Using AVWriter is more complicated and messy but allows for more options.

Depends on D14478

Test Plan

Send some videos on some devices and verify they're transcoded correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Mar 20 2025, 4:46 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 20 2025, 4:46 AM
angelika added a child revision: D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.Mar 20 2025, 4:47 AM
Harbormaster completed remote builds in B33786: Diff 47490.Mar 20 2025, 5:15 AM
angelika edited the summary of this revision. (Show Details)Mar 20 2025, 5:26 AM
angelika edited the summary of this revision. (Show Details)
angelika added inline comments.Mar 20 2025, 5:31 AM
native/expo-modules/comm-expo-package/ios/MediaModule.swift
193 ↗(On Diff #47490)

This is -movflags +faststart from ffmpeg

angelika published this revision for review.Mar 20 2025, 5:57 AM
bartek accepted this revision.Mar 21 2025, 8:52 AM

Nice work!

This revision is now accepted and ready to land.Mar 21 2025, 8:52 AM
angelika updated this revision to Diff 47555.Tue, Mar 25, 10:05 PM

Rebase & fix

Harbormaster completed remote builds in B33837: Diff 47555.Tue, Mar 25, 10:43 PM
angelika updated this revision to Diff 47590.Thu, Mar 27, 7:28 AM

Fix rotation issue on android video

Harbormaster failed remote builds in B33857: Diff 47590!Thu, Mar 27, 7:37 AM
Harbormaster completed remote builds in B33857: Diff 47590.Thu, Mar 27, 9:07 AM
Closed by commit rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS.

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
ios/
235 lines

Diff 47605

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

Loading...