Page MenuHomePhabricator
Differential D14480

[native] Use transcodeVideo() from MediaModule instead of ffmpeg
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:47 AM.
Tags
None
Referenced Files
F5770647: D14480.id47491.diff
Mon, Apr 14, 8:26 PM
Unknown Object (File)
Sun, Apr 13, 5:18 AM
Unknown Object (File)
Sun, Apr 13, 12:12 AM
Unknown Object (File)
Fri, Apr 11, 8:41 AM
Unknown Object (File)
Thu, Apr 10, 8:33 PM
Unknown Object (File)
Thu, Apr 10, 1:58 PM
Unknown Object (File)
Thu, Apr 10, 11:07 AM
Unknown Object (File)
Thu, Apr 10, 7:29 AM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14479

Test Plan

Send some videos on some devices and verify they're transcoded correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Thu, Mar 20, 4:47 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:47 AM
angelika added a child revision: D14481: [native] Remove ffmpeg dependency.Thu, Mar 20, 4:48 AM
Harbormaster completed remote builds in B33787: Diff 47491.Thu, Mar 20, 5:24 AM
angelika added inline comments.Thu, Mar 20, 5:38 AM
lib/types/media-types.js
107 ↗(On Diff #47491)

I'm returning some basic stats (speed, size and duration) but some are missing compared to ffmpeg implementation because I don't see much sense in collecting them. However I can add them if necessary (should be easy on Android, more complicated on iOS)

118 ↗(On Diff #47491)

We don't have return code anymore but we throw exceptions

angelika updated this revision to Diff 47502.Thu, Mar 20, 5:52 AM

Fix

angelika published this revision for review.Thu, Mar 20, 5:57 AM
Harbormaster completed remote builds in B33798: Diff 47502.Thu, Mar 20, 6:11 AM
bartek accepted this revision.Sun, Mar 23, 11:44 PM

Looks much cleaner now

This revision is now accepted and ready to land.Sun, Mar 23, 11:44 PM
angelika updated this revision to Diff 47556.Tue, Mar 25, 10:06 PM

Rebase

Harbormaster completed remote builds in B33838: Diff 47556.Tue, Mar 25, 10:46 PM
angelika updated this revision to Diff 47592.Thu, Mar 27, 9:08 AM

Set bitrate to 4000 kb/s

Harbormaster failed remote builds in B33859: Diff 47592!Thu, Mar 27, 9:17 AM
Harbormaster completed remote builds in B33859: Diff 47592.Thu, Mar 27, 12:05 PM
Closed by commit rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Revision Contents
Changeset List

PathSize
lib/
media/
65 lines
types/
5 lines
native/
media/
44 lines
35 lines
utils/
51 lines

Diff 47606

View Options

lib/media/video-utils.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };
View Options

lib/types/media-types.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };
View Options

native/media/ffmpeg.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };
View Options

native/media/video-utils.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };
View Options

native/utils/media-module.js

Loading...