Differential D14473

[ios] Implement hasMultipleFrames() function on iOS
AcceptedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:39 AM.

Details

Reviewers

bartek

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14472

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:39 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:39 AM

angelika added a child revision: D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.Thu, Mar 20, 4:40 AM

Harbormaster failed remote builds in B33780: Diff 47484!Thu, Mar 20, 4:59 AM

Harbormaster completed remote builds in B33780: Diff 47484.Thu, Mar 20, 5:33 AM

angelika published this revision for review.Thu, Mar 20, 5:56 AM

bartek accepted this revision.Fri, Mar 21, 1:52 AM

This revision is now accepted and ready to land.Fri, Mar 21, 1:52 AM

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

ios/

MediaModule.swift

17 lines

Diff 47484

View Options

native/expo-modules/comm-expo-package/ios/MediaModule.swift

[ios] Implement hasMultipleFrames() function on iOSAcceptedPublicActions