Differential D14480

[native] Use transcodeVideo() from MediaModule instead of ffmpeg
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 1, 1:43 AM

	Unknown Object (File)
	Tue, Apr 1, 1:02 AM

	Unknown Object (File)
	Mon, Mar 31, 7:39 PM

	Unknown Object (File)
	Mon, Mar 31, 4:31 PM

	Unknown Object (File)
	Mon, Mar 31, 4:27 AM

	Unknown Object (File)
	Sun, Mar 30, 9:11 PM

	Unknown Object (File)
	Sun, Mar 30, 8:48 PM

	Unknown Object (File)
	Sun, Mar 30, 1:15 PM

View All 26 Files

Subscribers

Details

Reviewers

Commits

rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14479

Test Plan

Send some videos on some devices and verify they're transcoded correctly

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Thu, Mar 20, 4:47 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:47 AM

angelika added a child revision: D14481: [native] Remove ffmpeg dependency.Thu, Mar 20, 4:48 AM

Harbormaster completed remote builds in B33787: Diff 47491.Thu, Mar 20, 5:24 AM

angelika added inline comments.Thu, Mar 20, 5:38 AM

lib/types/media-types.js
107 ↗	(On Diff #47491)	I'm returning some basic stats (speed, size and duration) but some are missing compared to ffmpeg implementation because I don't see much sense in collecting them. However I can add them if necessary (should be easy on Android, more complicated on iOS)
118 ↗	(On Diff #47491)	We don't have return code anymore but we throw exceptions

Fix

angelika published this revision for review.Thu, Mar 20, 5:57 AM

Harbormaster completed remote builds in B33798: Diff 47502.Thu, Mar 20, 6:11 AM

Looks much cleaner now

This revision is now accepted and ready to land.Sun, Mar 23, 11:44 PM

Rebase

Harbormaster completed remote builds in B33838: Diff 47556.Tue, Mar 25, 10:46 PM

Set bitrate to 4000 kb/s

Harbormaster failed remote builds in B33859: Diff 47592!Thu, Mar 27, 9:17 AM

Harbormaster completed remote builds in B33859: Diff 47592.Thu, Mar 27, 12:05 PM

Closed by commit rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Revision Contents
Changeset List

Path

Size

lib/

media/

65 lines

types/

5 lines

native/

media/

44 lines

35 lines

utils/

media-module.js

51 lines

Diff 47606

lib/media/video-utils.js

Loading...

lib/types/media-types.js

Loading...

native/media/ffmpeg.js

Loading...

native/media/video-utils.js

Loading...

native/utils/media-module.js

Loading...