Page MenuHomePhabricator
Differential D14475

[android] Implement generateThumbnail() function on Android
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:41 AM.
Tags
None
Referenced Files
F6200020: D14475.id47551.diff
Wed, Apr 23, 6:59 PM
F6190840: D14475.diff
Wed, Apr 23, 12:42 PM
Unknown Object (File)
Sun, Apr 13, 9:16 PM
Unknown Object (File)
Sun, Apr 13, 5:01 PM
Unknown Object (File)
Sun, Apr 13, 11:26 AM
Unknown Object (File)
Sat, Apr 12, 5:08 PM
Unknown Object (File)
Thu, Apr 10, 1:24 PM
Unknown Object (File)
Thu, Apr 10, 7:59 AM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14474

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
media/
36 lines

Diff 47551

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });