Page MenuHomePhabricator
Differential D14472

[android] Implement hasMultipleFrames() function on Android
ClosedPublic
Actions

Authored by angelika on Mar 20 2025, 4:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 1:11 PM
Unknown Object (File)
Thu, Apr 17, 1:54 PM
Unknown Object (File)
Mon, Apr 14, 8:16 AM
Unknown Object (File)
Sat, Apr 12, 7:32 AM
Unknown Object (File)
Thu, Apr 10, 8:25 AM
Unknown Object (File)
Wed, Apr 9, 4:53 PM
Unknown Object (File)
Wed, Apr 9, 4:39 PM
Unknown Object (File)
Sun, Apr 6, 6:38 PM
View All 35 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14471

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Mar 20 2025, 4:38 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 20 2025, 4:38 AM
angelika added a child revision: D14473: [ios] Implement hasMultipleFrames() function on iOS.Mar 20 2025, 4:39 AM
Harbormaster completed remote builds in B33779: Diff 47483.Mar 20 2025, 4:56 AM
angelika added inline comments.Mar 20 2025, 5:05 AM
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91 ↗(On Diff #47483)

Movie is deprecated but AnimatedImageDrawable is available only for Android 9+. According to our build.gradle we're supporting Android 8.0+ so I put both versions and a check here.

angelika published this revision for review.Mar 20 2025, 5:56 AM
bartek accepted this revision.Mar 21 2025, 1:51 AM
bartek added inline comments.
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91 ↗(On Diff #47483)

👍

This revision is now accepted and ready to land.Mar 21 2025, 1:51 AM
angelika updated this revision to Diff 47548.Tue, Mar 25, 10:02 PM

Rebase

Harbormaster completed remote builds in B33830: Diff 47548.Tue, Mar 25, 10:21 PM
Closed by commit rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android.

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
media/
41 lines

Diff 47598

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

// @flow // @flow
export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE
? process.env.COMM_NODE_ROLE === 'primary' ? process.env.COMM_NODE_ROLE === 'primary'
: true; : true;
export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE
? process.env.COMM_NODE_ROLE === 'secondary' ? process.env.COMM_NODE_ROLE === 'secondary'
: false; : false;
export const isAuxiliaryNode: boolean = process.env.COMM_NODE_ROLE
? process.env.COMM_NODE_ROLE === 'auxiliary'
: false;