Paths

Table of Contentst

-
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/
-
expo-modules/
-
comm-expo-package/
-
android/
-
src/
-
main/
-
java/
-
app/
-
comm/
-
android/
-
media/
-
MediaModule.kt

Differential D14472

[android] Implement hasMultipleFrames() function on Android
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:38 AM.

Details

Reviewers

bartek

Commits

rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14471

Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:38 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:38 AM

angelika added a child revision: D14473: [ios] Implement hasMultipleFrames() function on iOS.Thu, Mar 20, 4:39 AM

Harbormaster completed remote builds in B33779: Diff 47483.Thu, Mar 20, 4:56 AM

angelika added inline comments.Thu, Mar 20, 5:05 AM

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91 ↗	(On Diff #47483)	`Movie` is deprecated but `AnimatedImageDrawable` is available only for Android 9+. According to our build.gradle we're supporting Android 8.0+ so I put both versions and a check here.

angelika published this revision for review.Thu, Mar 20, 5:56 AM

bartek accepted this revision.Fri, Mar 21, 1:51 AM

bartek added inline comments.

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91 ↗	(On Diff #47483)	👍

This revision is now accepted and ready to land.Fri, Mar 21, 1:51 AM

Rebase

Harbormaster completed remote builds in B33830: Diff 47548.Tue, Mar 25, 10:21 PM

Closed by commit rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

android/

src/

main/

java/

app/

comm/

android/

media/

MediaModule.kt

41 lines

Diff 47548

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines	infoValidator: tShape<ThreadJoinUpdateInfo>({
type: tNumber(updateTypes.JOIN_THREAD),		type: tNumber(updateTypes.JOIN_THREAD),
id: t.String,		id: t.String,
time: t.Number,		time: t.Number,
threadInfo: mixedRawThreadInfoValidator,		threadInfo: mixedRawThreadInfoValidator,
rawMessageInfos: t.list(rawMessageInfoValidator),		rawMessageInfos: t.list(rawMessageInfoValidator),
truncationStatus: messageTruncationStatusValidator,		truncationStatus: messageTruncationStatusValidator,
rawEntryInfos: t.list(rawEntryInfoValidator),		rawEntryInfos: t.list(rawEntryInfoValidator),
}),		}),
		getUpdatedThreadInfo: (update: ThreadJoinUpdateInfo) => update.threadInfo,
});		});

[android] Implement hasMultipleFrames() function on AndroidClosedPublicActions