Paths

Table of Contentst

-
lib/types/
-
types/
-
media-types.js
-
native/
-
android/
-
build.gradle
-
ios/
-
Comm.xcodeproj/
-
project.pbxproj
-
Podfile
-
Podfile.lock
-
media/
-
ffmpeg.js
-
file-utils.js
-
media-processing-queue.js
-
video-utils.js
-
package.json
-
yarn.lock

Differential D14481

[native] Remove ffmpeg dependency
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:48 AM.

Details

Reviewers

bartek

Commits

rCOMM2fb795a199b7: [native] Remove ffmpeg dependency

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

got rid of ffmpeg dependency
renamed ffmpeg.js to mediaProcessingQueue.js because the main feature of this file is the queue and wrapping functions from the media module
reanamed FFmpegStatistics and video_ffmpeg_transcode step

Depends on D14480

Test Plan

Compile the app and verify sending videos still work

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Thu, Mar 20, 4:48 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:48 AM

Harbormaster completed remote builds in B33788: Diff 47492.Thu, Mar 20, 5:22 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 5:41 AM

Rebase

angelika published this revision for review.Thu, Mar 20, 5:57 AM

Harbormaster completed remote builds in B33799: Diff 47503.Thu, Mar 20, 6:11 AM

Wondering how much smaller our binaries will be without ffmpeg 😀

This revision is now accepted and ready to land.Fri, Mar 21, 8:57 AM

ashoat added inline comments.Fri, Mar 21, 4:13 PM

native/media/media-processing-queue.js
31 ↗	(On Diff #47503)	Do we still need this synchronous queue? We previously had it because of limitations in `ffmpeg-kit`, but it reduces performance when a user uploads multiple media in a single message

bartek added inline comments.Sun, Mar 23, 11:55 PM

native/media/media-processing-queue.js
31 ↗	(On Diff #47503)	I was thinking about this too, but I have a suspicion that mobile devices can struggle with processing multiple videos simultaneously and CPU performance will be a limiting factor

Rebase

angelika added inline comments.Tue, Mar 25, 10:21 PM

native/media/media-processing-queue.js
31 ↗	(On Diff #47503)	Tested it and: It's very slow Reporting progress currently works for one video at a time - we can implement progress for multiple videos (for example by adding video id to the progress event) but it's some additional work

Harbormaster completed remote builds in B33839: Diff 47557.Tue, Mar 25, 10:49 PM

Closed by commit rCOMM2fb795a199b7: [native] Remove ffmpeg dependency (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM2fb795a199b7: [native] Remove ffmpeg dependency.

Revision Contents
Changeset List

Path

Size

lib/

types/

media-types.js

6 lines

native/

android/

build.gradle

4 lines

ios/

Comm.xcodeproj/

project.pbxproj

16 lines

Podfile

1 line

Podfile.lock

12 lines

media/

ffmpeg.js

file-utils.js

4 lines

	media-processing-queue.js
	ffmpeg.js

15 lines

video-utils.js

11 lines

package.json

1 line

yarn.lock

5 lines

Diff 47607

View Options

lib/types/media-types.js

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines	export type UploadMediaMetadataRequest = {
+blobHolder: string,		+blobHolder: string,
+blobHash: string,		+blobHash: string,
+encryptionKey: string,		+encryptionKey: string,
+mimeType: string,		+mimeType: string,
+loop?: boolean,		+loop?: boolean,
+thumbHash?: string,		+thumbHash?: string,
};		};

export type FFmpegStatistics = {		export type TranscodingStatistics = {
// seconds of video being processed per second		// seconds of video being processed per second
+speed: number,		+speed: number,
// total milliseconds of video processed so far		// total milliseconds of video processed so far
+time: number,		+time: number,
// total result file size in bytes so far		// total result file size in bytes so far
+size: number,		+size: number,
};		};

export type TranscodeVideoMediaMissionStep = {		export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode',		+step: 'video_transcode',
+success: boolean,		+success: boolean,
+exceptionMessage: ?string,		+exceptionMessage: ?string,
+time: number, // ms		+time: number, // ms
+newPath: ?string,		+newPath: ?string,
+stats: ?FFmpegStatistics,		+stats: ?TranscodingStatistics,
};		};

export type VideoGenerateThumbnailMediaMissionStep = {		export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail',		+step: 'video_generate_thumbnail',
+success: boolean,		+success: boolean,
+time: number, // ms		+time: number, // ms
+exceptionMessage: ?string,		+exceptionMessage: ?string,
+thumbnailURI: string,		+thumbnailURI: string,
▲ Show 20 Lines • Show All 696 Lines • Show Last 20 Lines

View Options

native/android/build.gradle

View Options

native/ios/Comm.xcodeproj/project.pbxproj

View Options

native/ios/Podfile

	require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")			require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
	require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")			require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
	require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")			require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")

	platform :ios, '13.0'			platform :ios, '13.0'
	install! 'cocoapods', :deterministic_uuids => false			install! 'cocoapods', :deterministic_uuids => false

	require 'json'			require 'json'

	def common_comm_target_pods			def common_comm_target_pods
	pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'			pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'
	pod 'react-native-video/VideoCaching', :podspec => '../node_modules/react-native-video'			pod 'react-native-video/VideoCaching', :podspec => '../node_modules/react-native-video'
	pod 'ffmpeg-kit-react-native', :subspecs => ['min'], :podspec => '../node_modules/ffmpeg-kit-react-native'
	end			end

	post_integrate do \|installer\|			post_integrate do \|installer\|
	begin			begin
	expo_patch_react_imports!(installer)			expo_patch_react_imports!(installer)
	rescue => e			rescue => e
	Pod::UI.warn e			Pod::UI.warn e
	end			end
	▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines