issue: ENG-6576
This diff contains hacks that should allow adding a second keyserver form a client
Details
Details
- Reviewers
- None
This is hard to test because I'm having trouble loging in using the identity flow, but I did thest this in the following way:
- I was logged in with the old flow
- I checked that in the keyservers screen, the authoritative keyserver does show up
- I tried adding a second keyserver (which I had running in Docker) - checked that it showed up on the list of keyservers as well. I didn't get logged in to, because I didn't have the CSAT
For the identity changes:
- I was logged out
- I typed in crenetials of a user that was registered with identity
- I checked that CSAT is being saved
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/testing_multikeyservers
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/selectors/keyserver-selectors.js | ||
|---|---|---|
| 129–130 ↗ | (On Diff #37442) | We might not have the keyservers admin in userStore |
| 137 ↗ | (On Diff #37442) | Admin id is the same as keyserver id |
| lib/utils/services-utils.js | ||
| 7 ↗ | (On Diff #37442) | This flag lets us actually use the identity code |
| native/account/log-in-panel.react.js | ||
| 335–340 ↗ | (On Diff #37442) | We need to save the access token to commCoreModule, so that comm services auth metadata emitter can emit it back to js code that listens for it Handling this correctly is tracked in ENG-6606 |
| web/account/account-hooks.js | ||
| 337–340 ↗ | (On Diff #37442) | Clients and keyservers use a different format of the prey key. This is a workaround for now. Fixing this is for now tracked in ENG-6902 |
| web/redux/action-types.js | ||
| 48–59 ↗ | (On Diff #37442) | This is not needed if we are actually connecting to the keyservers we add to our store |
Comment Actions
Love to see more hacks getting removed here!
| lib/reducers/services-access-token-reducer.js | ||
|---|---|---|
| 7 ↗ | (On Diff #38981) | Nit: this change can be removed |
| native/account/log-in-panel.react.js | ||
|---|---|---|
| 329–334 ↗ | (On Diff #38981) | Same as below; should be covered by IdentityServiceContextProvider.logInPasswordUser |
| native/account/registration/registration-server-call.js | ||
| 101–106 ↗ | (On Diff #38981) | Wondering – why is this necessary? It seems like there is a setCommServicesAuthMetadata call inside IdentityServiceContextProvider.registerPasswordUser, which was introduced in D11021 It looks like that change was landed shortly after this diff was first introduced, so I suspect you had it here initially because it was necessary, but it likely is not necessary anymore |
| web/redux/action-types.js | ||
|---|---|---|
| 48–59 | Ping on this! | |
| web/redux/action-types.js | ||
|---|---|---|
| 48–59 | Yes, I think we can do that! | |