Page MenuHomePhabricator
Differential D11193

[terraform] expose allow origin list to identity service via terraform
ClosedPublic
Actions

Authored by varun on Feb 28 2024, 10:31 PM.
Tags
None
Referenced Files
F3360278: D11193.diff
Sun, Nov 24, 12:35 PM
Unknown Object (File)
Tue, Nov 12, 3:31 PM
Unknown Object (File)
Tue, Nov 12, 3:30 PM
Unknown Object (File)
Tue, Nov 12, 3:30 PM
Unknown Object (File)
Tue, Nov 12, 3:23 PM
Unknown Object (File)
Tue, Nov 12, 3:20 PM
Unknown Object (File)
Tue, Nov 12, 11:35 AM
Unknown Object (File)
Mon, Nov 11, 2:47 PM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM7f908783d773: [terraform] expose allow origin list to identity service via terraform
Summary

we'll configure the CORS policy accordingly

Test Plan

tested in subsequent diff by actually using the provided list

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Feb 28 2024, 10:31 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 28 2024, 10:31 PM
varun added a child revision: D11194: [identity] add allow origin list to config struct.Feb 28 2024, 10:35 PM
Harbormaster completed remote builds in B27223: Diff 37682.Feb 28 2024, 10:47 PM
varun requested review of this revision.Feb 28 2024, 10:47 PM
will accepted this revision.Feb 29 2024, 11:54 AM
This revision is now accepted and ready to land.Feb 29 2024, 11:54 AM
varun updated this revision to Diff 37731.Mar 1 2024, 12:27 PM

make the allow origin list more configurable

varun requested review of this revision.Mar 1 2024, 12:39 PM

@will can you give this one more pass? it's changed quite a bit

services/terraform/remote/service_identity.tf
24 ↗(On Diff #37731)

EOT lets us write multiline strings cleanly

Harbormaster completed remote builds in B27254: Diff 37731.Mar 1 2024, 12:42 PM
will accepted this revision.Mar 1 2024, 12:53 PM

Looks good to me. Might want to adjust the diff title and test plan but that's really it.

This revision is now accepted and ready to land.Mar 1 2024, 12:53 PM
varun updated this revision to Diff 37858.Mar 5 2024, 9:38 AM
varun retitled this revision from [terraform] expose remote environment type to identity service as env var to [terraform] expose allow origin list to identity service via terraform.
varun edited the test plan for this revision. (Show Details)

updating title

Harbormaster completed remote builds in B27340: Diff 37858.Mar 5 2024, 10:05 AM
Closed by commit rCOMM7f908783d773: [terraform] expose allow origin list to identity service via terraform (authored by varun). · Explain WhyMar 5 2024, 12:46 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM7f908783d773: [terraform] expose allow origin list to identity service via terraform.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
6 lines

Diff 37682

View Options

services/terraform/remote/service_identity.tf

Loading...