Page MenuHomePhabricator
Differential D11199

[native] Fix typo in encrypted-image
ClosedPublic
Actions

Authored by tomek on Feb 29 2024, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 4:58 AM
Unknown Object (File)
Wed, Apr 16, 3:36 PM
Unknown Object (File)
Wed, Apr 16, 1:09 PM
Unknown Object (File)
Wed, Apr 16, 1:36 AM
Unknown Object (File)
Tue, Apr 15, 9:23 PM
Unknown Object (File)
Tue, Apr 15, 1:04 PM
Unknown Object (File)
Sat, Mar 29, 9:05 AM
Unknown Object (File)
Feb 16 2025, 12:45 AM
View All Files
Subscribers
ashoat

Details

Reviewers
atul
inka
kamil
Commits
rCOMM014aefa51383: [native] Fix typo in encrypted-image
Summary

Fix the typo

Depends on D11197

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
sockets
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Feb 29 2024, 6:49 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 29 2024, 6:49 AM
tomek retitled this revision from [native] Fix typo in encrypted-message to [native] Fix typo in encrypted-image.Feb 29 2024, 6:59 AM
Harbormaster completed remote builds in B27236: Diff 37695.Feb 29 2024, 7:04 AM
tomek requested review of this revision.Feb 29 2024, 7:04 AM
kamil accepted this revision.Feb 29 2024, 7:25 AM
kamil added inline comments.
native/media/encrypted-image.react.js
113 ↗(On Diff #37695)

I guess we should also rename prop 😆

This revision is now accepted and ready to land.Feb 29 2024, 7:25 AM
tomek updated this revision to Diff 37701.Feb 29 2024, 7:27 AM
tomek marked an inline comment as done.

Fix typo

Harbormaster failed remote builds in B27239: Diff 37701!Feb 29 2024, 7:39 AM
Harbormaster completed remote builds in B27239: Diff 37701.Feb 29 2024, 7:43 AM
Closed by commit rCOMM014aefa51383: [native] Fix typo in encrypted-image (authored by tomek). · Explain WhyFeb 29 2024, 7:45 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM014aefa51383: [native] Fix typo in encrypted-image.

Revision Contents
Changeset List

PathSize
native/
media/
6 lines
6 lines

Diff 37701

View Options

native/media/encrypted-image.react.js

Show All 33 Linesfunction EncryptedImage(props: Props): React.Node {
const fetchAndDecryptMedia = useFetchAndDecryptMedia(); const fetchAndDecryptMedia = useFetchAndDecryptMedia();
const mediaCache = React.useContext(MediaCacheContext); const mediaCache = React.useContext(MediaCacheContext);
const [source, setSource] = React.useState<?ImageSource>(null); const [source, setSource] = React.useState<?ImageSource>(null);
const connected = useSelector(state => state.connectivity.connected); const connected = useSelector(state => state.connectivity.connected);
const prevConnectedRef = React.useRef(connected); const prevConnectedRef = React.useRef(connected);
const [attempt, setAttempt] = React.useState(0); const [attempt, setAttempt] = React.useState(0);
const [errorOccured, setErrorOccured] = React.useState(false); const [errorOccurred, setErrorOccurred] = React.useState(false);
if (prevConnectedRef.current !== connected) { if (prevConnectedRef.current !== connected) {
if (!source && connected) { if (!source && connected) {
setAttempt(attempt + 1); setAttempt(attempt + 1);
} }
prevConnectedRef.current = connected; prevConnectedRef.current = connected;
} }
Show All 27 Lines const loadDecrypted = async () => {
destination: 'data_uri', destination: 'data_uri',
}); });
if (isMounted) { if (isMounted) {
if (result.success) { if (result.success) {
void mediaCache?.set(blobURI, result.uri); void mediaCache?.set(blobURI, result.uri);
setSource({ uri: result.uri }); setSource({ uri: result.uri });
} else { } else {
setErrorOccured(true); setErrorOccurred(true);
} }
} }
}; };
void loadDecrypted(); void loadDecrypted();
return () => { return () => {
isMounted = false; isMounted = false;
Show All 10 Lines return (
<LoadableImage <LoadableImage
placeholder={placeholder} placeholder={placeholder}
source={source} source={source}
onLoad={onLoad} onLoad={onLoad}
spinnerColor={spinnerColor} spinnerColor={spinnerColor}
style={style} style={style}
invisibleLoad={invisibleLoad} invisibleLoad={invisibleLoad}
key={attempt} key={attempt}
errorOccured={errorOccured} errorOccurred={errorOccurred}
/> />
); );
} }
export default EncryptedImage; export default EncryptedImage;
View Options

native/media/loadable-image.react.js

Show All 10 Lines
type Props = { type Props = {
+placeholder: ?ImageSource, +placeholder: ?ImageSource,
+source: ?ImageSource, +source: ?ImageSource,
+onLoad?: () => void, +onLoad?: () => void,
+spinnerColor: string, +spinnerColor: string,
+style: ImageStyle, +style: ImageStyle,
+invisibleLoad: boolean, +invisibleLoad: boolean,
+errorOccured?: boolean, +errorOccurred?: boolean,
}; };
function LoadableImage(props: Props): React.Node { function LoadableImage(props: Props): React.Node {
const { source, placeholder, onLoad: onLoadProp, errorOccured } = props; const { source, placeholder, onLoad: onLoadProp, errorOccurred } = props;
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const [loaded, setLoaded] = React.useState(false); const [loaded, setLoaded] = React.useState(false);
const [error, setError] = React.useState(false); const [error, setError] = React.useState(false);
const onError = React.useCallback(() => { const onError = React.useCallback(() => {
setError(true); setError(true);
}, []); }, []);
Show All 17 Lines return (
onLoad={onLoad} onLoad={onLoad}
onError={onError} onError={onError}
style={invisibleStyle} style={invisibleStyle}
/> />
); );
} }
let statusIndicator; let statusIndicator;
if (error || errorOccured) { if (error || errorOccurred) {
statusIndicator = ( statusIndicator = (
<View style={styles.statusIndicatorContainer}> <View style={styles.statusIndicatorContainer}>
<Icon name="alert-circle" style={styles.errorIndicator} size={42} /> <Icon name="alert-circle" style={styles.errorIndicator} size={42} />
</View> </View>
); );
} else if (!loaded) { } else if (!loaded) {
statusIndicator = ( statusIndicator = (
<View style={styles.statusIndicatorContainer}> <View style={styles.statusIndicatorContainer}>
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines