This introduces the necessary code to call C++ integrity store sqlite ops from native
Depends on D11300
Paths
| Differential D11306 Authored by will on Mar 11 2024, 12:16 PM.
Details
Summary This introduces the necessary code to call C++ integrity store sqlite ops from native Depends on D11300 Test Plan Ran the following code: async function run_test() { console.log('running run_test()'); const TEST_THREAD_HASHES_1: $ReadOnlyArray<ClientDBIntegrityThreadHash> = [ { id: '256|2202182', threadHash: 2304934 }, ]; const TEST_THREAD_HASHES_2: $ReadOnlyArray<ClientDBIntegrityThreadHash> = [ { id: '256|2204191', threadHash: 1029853 }, { id: '256|2205980', threadHash: 3119392 }, { id: '256|2208693', threadHash: 4157082 }, { id: '256|2210486', threadHash: 3425604 }, { id: '256|2212631', threadHash: 8951764 }, ]; await commCoreModule.processIntegrityStoreOperations([ { type: 'replace_integrity_thread_hashes', payload: { threadHashes: TEST_THREAD_HASHES_1, }, }, { type: 'remove_all_integrity_thread_hashes', }, { type: 'replace_integrity_thread_hashes', payload: { threadHashes: TEST_THREAD_HASHES_2, }, }, { type: 'remove_integrity_thread_hashes', payload: { ids: ['256|2205980', '256|2212631'], }, }, ]); } After calling run_test(), sqlite table on native matches intended operation result:
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptMar 11 2024, 12:16 PM2024-03-11 12:16:46 (UTC-7) will edited the test plan for this revision. (Show Details)Mar 11 2024, 12:17 PM2024-03-11 12:17:01 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Mar 11 2024, 12:58 PM2024-03-11 12:58:25 (UTC-7) Harbormaster failed remote builds in B27459: Diff 38008!Mar 11 2024, 10:38 PM2024-03-11 22:38:56 (UTC-7) Comment Actions Make sure Android build passes before landing
This revision is now accepted and ready to land.Mar 12 2024, 10:18 AM2024-03-12 10:18:11 (UTC-7) Harbormaster completed remote builds in B27573: Diff 38153.Mar 18 2024, 9:48 PM2024-03-18 21:48:17 (UTC-7) will removed a parent revision: D11300: [sqlite] add methods to operate on integrity store table.Mar 25 2024, 1:38 PM2024-03-25 13:38:41 (UTC-7) Closed by commit rCOMM03b900a71b56: [sqlite] implement C++ integrity store ops (authored by will). · Explain WhyMar 25 2024, 2:11 PM2024-03-25 14:11:10 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 38315 native/cpp/CommonCpp/NativeModules/CMakeLists.txt
native/cpp/CommonCpp/NativeModules/CommCoreModule.h
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
native/cpp/CommonCpp/NativeModules/IntegrityStoreOperations.h
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/IntegrityStore.h
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/IntegrityStore.cpp
native/cpp/CommonCpp/_generated/commJSI-generated.cpp
|