Page MenuHomePhabricator
Differential D11315

[lib] Refactor user reducers
ClosedPublic
Actions

Authored by inka on Mar 13 2024, 10:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 1:26 AM
Unknown Object (File)
Thu, Apr 3, 10:18 PM
Unknown Object (File)
Tue, Apr 1, 9:46 PM
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Mar 21 2025, 11:48 AM
Unknown Object (File)
Feb 27 2025, 7:27 PM
Unknown Object (File)
Feb 27 2025, 7:27 PM
Unknown Object (File)
Feb 26 2025, 7:17 AM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM53224dfd79b5: [lib] Refactor user reducers
Summary

issue: ENG-6485
incrementalStateSyncActionType, processUpdatesActionType and processServerRequestsActionType are actions dispatched for one keyserver. They should not be changing currentUserInfo or userStore, unles the keyserver is the authoritative keyserver and relyingOnAuthoritativeKeyserver is true

Test Plan

Tested that for clients set up to rely on the authoritative keyserver incremental state sync updates currentUserInfo and userStore

Diff Detail

Repository
rCOMM Comm
Branch
inka/state_sync
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
reducers/
32 lines

Diff 38042

View Options

lib/reducers/user-reducer.js

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines async keyserverAuthInfo => {
const responses: { +[string]: ClientLogInResponse } = const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'keyserver_auth', 'keyserver_auth',
requests, requests,
keyserverAuthCallSingleKeyserverEndpointOptions, keyserverAuthCallSingleKeyserverEndpointOptions,
); );
const userInfosArrays = [];
let threadInfos: RawThreadInfos = {}; let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = { const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery, calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [], rawEntryInfos: [],
}; };
const messagesResult: WritableGenericMessagesResult = { const messagesResult: WritableGenericMessagesResult = {
messageInfos: [], messageInfos: [],
truncationStatus: {}, truncationStatus: {},
Show All 21 Lines for (const keyserverID in responses) {
messagesResult.currentAsOf = { messagesResult.currentAsOf = {
...messagesResult.currentAsOf, ...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
updatesCurrentAsOf = { updatesCurrentAsOf = {
...updatesCurrentAsOf, ...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
} }
const userInfosArrays = [
responses[authoritativeKeyserverID()].userInfos,
responses[authoritativeKeyserverID()].cookieChange.userInfos,
tomekUnsubmitted
Not Done
Inline Actions

I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.

tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
];
const userInfos = mergeUserInfos(...userInfosArrays); const userInfos = mergeUserInfos(...userInfosArrays);
return { return {
threadInfos, threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo, currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult, calendarResult,
messagesResult, messagesResult,
userInfos, userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines