Page MenuHomePhabricator

[lib] Handle processing of the ops
ClosedPublic

Authored by tomek on Mar 21 2024, 8:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 4:09 AM
Unknown Object (File)
Wed, Nov 13, 1:19 AM
Unknown Object (File)
Wed, Nov 13, 1:19 AM
Unknown Object (File)
Wed, Nov 13, 1:19 AM
Unknown Object (File)
Wed, Nov 13, 1:19 AM
Unknown Object (File)
Oct 11 2024, 10:34 AM
Unknown Object (File)
Oct 11 2024, 10:34 AM
Unknown Object (File)
Oct 11 2024, 10:34 AM
Subscribers

Details

Summary

We're processing the actions one by one and report successful processing after it is done.

https://linear.app/comm/issue/ENG-7098/create-a-handler-that-processes-the-ops

Depends on D11366

Test Plan

Added a sleep to the handler after calling processDBStoreOperations and observed in Redux debugger that the ops were processed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2024, 8:31 AM
Harbormaster failed remote builds in B27648: Diff 38269!
tomek added inline comments.
lib/handlers/db-ops-handler.react.js
22

It might happen that some dependencies change but we don't want to call processDBStoreOperations again to avoid duplicated processing of the ops.

tomek requested review of this revision.Mar 27 2024, 9:13 AM
kamil added inline comments.
lib/handlers/db-ops-handler.react.js
11

I think this can be more specific?

This revision is now accepted and ready to land.Mar 28 2024, 3:49 AM
lib/handlers/db-ops-handler.react.js
11

Yes, this can be. But overall, it is more convenient to make the inputs as general as possible - this makes the API more flexible.

This revision was automatically updated to reflect the committed changes.