Page MenuHomePhabricator
Differential D11367

[lib] Handle processing of the ops
ClosedPublic
Actions

Authored by tomek on Mar 21 2024, 8:20 AM.
Tags
None
Referenced Files
F5100468: D11367.id38371.diff
Mon, Mar 31, 1:05 PM
F5100331: D11367.id38269.diff
Mon, Mar 31, 12:30 PM
Unknown Object (File)
Sat, Mar 29, 10:54 PM
Unknown Object (File)
Thu, Mar 27, 2:41 PM
Unknown Object (File)
Feb 26 2025, 11:40 AM
Unknown Object (File)
Feb 26 2025, 11:40 AM
Unknown Object (File)
Feb 26 2025, 11:40 AM
Unknown Object (File)
Feb 26 2025, 11:34 AM
View All 87 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
will
Commits
rCOMMf6b18846b255: [lib] Handle processing of the ops
Summary

We're processing the actions one by one and report successful processing after it is done.

https://linear.app/comm/issue/ENG-7098/create-a-handler-that-processes-the-ops

Depends on D11366

Test Plan

Added a sleep to the handler after calling processDBStoreOperations and observed in Redux debugger that the ops were processed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Mar 21 2024, 8:20 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 21 2024, 8:20 AM
tomek edited the summary of this revision. (Show Details)Mar 21 2024, 8:21 AM
tomek added a child revision: D11368: [native][web] Remove processing the ops from reducers.Mar 21 2024, 8:23 AM
tomek edited the summary of this revision. (Show Details)Mar 21 2024, 8:28 AM
tomek edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2024, 8:31 AM
Harbormaster failed remote builds in B27648: Diff 38269!
tomek updated this revision to Diff 38371.Mar 27 2024, 8:57 AM

Use the new approach

tomek edited the summary of this revision. (Show Details)Mar 27 2024, 8:58 AM
tomek added inline comments.
lib/handlers/db-ops-handler.react.js
22

It might happen that some dependencies change but we don't want to call processDBStoreOperations again to avoid duplicated processing of the ops.

Harbormaster completed remote builds in B27708: Diff 38371.Mar 27 2024, 9:13 AM
tomek requested review of this revision.Mar 27 2024, 9:13 AM
kamil accepted this revision.Mar 28 2024, 3:49 AM
kamil added inline comments.
lib/handlers/db-ops-handler.react.js
11

I think this can be more specific?

This revision is now accepted and ready to land.Mar 28 2024, 3:49 AM
tomek added inline comments.Mar 28 2024, 4:05 AM
lib/handlers/db-ops-handler.react.js
11

Yes, this can be. But overall, it is more convenient to make the inputs as general as possible - this makes the API more flexible.

Closed by commit rCOMMf6b18846b255: [lib] Handle processing of the ops (authored by tomek). · Explain WhyMar 28 2024, 8:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMf6b18846b255: [lib] Handle processing of the ops.

Revision Contents
Changeset List

PathSize
lib/
handlers/
24 lines
types/
2 lines
native/
4 lines
web/
components/
20 lines
2 lines

Diff 38371

View Options

lib/handlers/db-ops-handler.react.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

lib/types/db-ops-types.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

native/root.react.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

web/components/db-ops-handler.react.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

web/root.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;