Page MenuHomePhabricator
Differential D11462

[native] implement onSuccess callback for ConnectFarcaster registration step
ClosedPublic
Actions

Authored by ginsu on Mar 28 2024, 9:43 PM.
Tags
None
Referenced Files
F5059007: D11462.id.diff
Wed, Mar 26, 8:34 AM
Unknown Object (File)
Mon, Mar 3, 11:22 PM
Unknown Object (File)
Wed, Feb 26, 11:34 AM
Unknown Object (File)
Feb 18 2025, 8:12 PM
Unknown Object (File)
Jan 24 2025, 7:12 AM
Unknown Object (File)
Jan 19 2025, 5:58 AM
Unknown Object (File)
Jan 5 2025, 4:51 PM
Unknown Object (File)
Jan 5 2025, 3:48 PM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step
Summary

This diff implements the onSuccess callback in the ConnectFarcaster screen. This callback gets called back whenever we successfully get the fid from the farcaster webview

Depends on D11461

Test Plan

Please see the demo video below + tested the entire sign in flow during the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 28 2024, 9:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 9:43 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 9:45 PM
Harbormaster failed remote builds in B27804: Diff 38521!
ginsu requested review of this revision.Mar 28 2024, 9:47 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11461: [native] add the connect farcaster step into the registration flow.
ginsu attached a referenced file: F1440319: RPReplay_Final1711658857.MP4. (Show Details)

will make sure ci passes before landing

ginsu added a child revision: D11463: [native] introduce already connected button to farcaster connect.Mar 28 2024, 10:08 PM
atul accepted this revision.Mar 29 2024, 1:19 PM
This revision is now accepted and ready to land.Mar 29 2024, 1:19 PM
Harbormaster completed remote builds in B27804: Diff 38521.Mar 29 2024, 2:14 PM
Closed by commit rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step (authored by ginsu). · Explain WhyMar 29 2024, 2:20 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
19 lines
1 line

Diff 38562

View Options

native/account/registration/connect-farcaster.react.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines
View Options

native/account/registration/registration-types.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines