Page MenuHomePhabricator
Differential D11461

[native] add the connect farcaster step into the registration flow
ClosedPublic
Actions

Authored by ginsu on Mar 28 2024, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 1:35 PM
Unknown Object (File)
Sun, Apr 7, 12:47 PM
Unknown Object (File)
Sun, Apr 7, 11:19 AM
Unknown Object (File)
Sun, Apr 7, 11:03 AM
Unknown Object (File)
Sun, Apr 7, 9:08 AM
Unknown Object (File)
Sat, Apr 6, 4:11 PM
Unknown Object (File)
Fri, Apr 5, 9:33 PM
Unknown Object (File)
Tue, Apr 2, 10:55 AM
View All 10 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow
Summary

This diff adds the ConnectFarcaster screen into the registration flow. We want to show the connect farcaster screen after the connect etherum screen.

In this diff we also need to add an optional fid field to Params of all the screens after connect farcaster + RegistrationServerCallInput in order to potentially pass an fid through the registration flow

Depends on D11442

Test Plan

Please see the demo video below + tested the entire sign in flow during the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 28 2024, 9:25 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 9:25 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 9:27 PM
Harbormaster failed remote builds in B27802: Diff 38519!
ginsu edited the summary of this revision. (Show Details)Mar 28 2024, 9:36 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11442: [native] introduce ConnectFarcaster registration screen.
ginsu updated this revision to Diff 38520.EditedMar 28 2024, 9:41 PM
ginsu edited the test plan for this revision. (Show Details)

fix? (ran yarn cleaninstall to try and fix keyserver build)

ginsu attached a referenced file: F1440207: Screen Recording 2024-03-29 at 12.30.59 AM.mov. (Show Details)Mar 28 2024, 9:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 9:43 PM
Harbormaster failed remote builds in B27803: Diff 38520!
ginsu added a comment.Mar 28 2024, 9:45 PM

will make sure ci passes before landing

ginsu requested review of this revision.Mar 28 2024, 9:45 PM
ginsu added a child revision: D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.
atul accepted this revision.Mar 29 2024, 1:18 PM
This revision is now accepted and ready to land.Mar 29 2024, 1:18 PM
Harbormaster completed remote builds in B27803: Diff 38520.Mar 29 2024, 2:14 PM
Closed by commit rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow (authored by ginsu). · Explain WhyMar 29 2024, 2:20 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow.

Revision Contents
Changeset List

Diff 38561

View Options

native/account/registration/avatar-selection.react.js

Loading...
View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/password-selection.react.js

Loading...
View Options

native/account/registration/registration-terms.react.js

Loading...
View Options

native/account/registration/registration-types.js

Loading...
View Options

native/account/registration/username-selection.react.js

Loading...