Page MenuHomePhabricator
Differential D11434

[native] introduce FarcasterLogo
ClosedPublic
Actions

Authored by ginsu on Mar 27 2024, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 1:38 PM
Unknown Object (File)
Thu, Apr 11, 9:58 PM
Unknown Object (File)
Sat, Apr 6, 8:58 PM
Unknown Object (File)
Sat, Apr 6, 12:44 PM
Unknown Object (File)
Fri, Apr 5, 10:02 PM
Unknown Object (File)
Fri, Apr 5, 9:33 PM
Unknown Object (File)
Fri, Apr 5, 1:14 PM
Unknown Object (File)
Wed, Apr 3, 10:03 AM
View All 15 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM3941d90cb605: [native] introduce FarcasterLogo
Summary

This diff introduces the FarcasterLogo component. This component will be consumed by a future FarcasterPrompt component (will be introduced in a subsequent diff)

Depends on D11432

Test Plan

Please see screenshot to see what the vector looks like:

Screenshot 2024-03-28 at 12.37.35 AM.png (1×1 px, 745 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 27 2024, 9:36 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 9:36 PM
ginsu edited the summary of this revision. (Show Details)Mar 27 2024, 9:38 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11432: [landing/lib/native] introduce FarcasterWebView.
ginsu attached a referenced file: F1430312: Screenshot 2024-03-28 at 12.37.35 AM.png. (Show Details)
Harbormaster completed remote builds in B27755: Diff 38418.Mar 27 2024, 10:06 PM
ginsu requested review of this revision.Mar 27 2024, 10:06 PM
atul accepted this revision.Mar 28 2024, 5:50 AM

Wouldn't hurt to memoize

native/vectors/farcaster-logo.react.js
7–28 ↗(On Diff #38418)

Seems like this would be an easy one to memoize

This revision is now accepted and ready to land.Mar 28 2024, 5:50 AM
ginsu updated this revision to Diff 38465.Mar 28 2024, 9:23 AM

address feedback

ginsu added a child revision: D11441: [native] introduce FarcasterPrompt.Mar 28 2024, 9:28 AM
Harbormaster completed remote builds in B27775: Diff 38465.Mar 28 2024, 9:38 AM
Closed by commit rCOMM3941d90cb605: [native] introduce FarcasterLogo (authored by ginsu). · Explain WhyMar 28 2024, 10:58 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3941d90cb605: [native] introduce FarcasterLogo.

Revision Contents
Changeset List

PathSize
native/
vectors/
36 lines

Diff 38485

View Options

native/vectors/farcaster-logo.react.js

Loading...