Details

Reviewers

Commits

rCOMM3941d90cb605: [native] introduce FarcasterLogo

Summary

This diff introduces the FarcasterLogo component. This component will be consumed by a future FarcasterPrompt component (will be introduced in a subsequent diff)

Depends on D11432

Test Plan

Please see screenshot to see what the vector looks like:

Screenshot 2024-03-28 at 12.37.35 AM.png (1×1 px, 745 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 28 2024, 4:36 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 4:36 AM

ginsu edited the summary of this revision. (Show Details)Mar 28 2024, 4:38 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a reviewer: atul.

ginsu added a parent revision: D11432: [landing/lib/native] introduce FarcasterWebView.

ginsu attached a referenced file: F1430312: Screenshot 2024-03-28 at 12.37.35 AM.png. (Show Details)

Harbormaster completed remote builds in B27755: Diff 38418.Mar 28 2024, 5:06 AM

ginsu requested review of this revision.Mar 28 2024, 5:06 AM

Wouldn't hurt to memoize

native/vectors/farcaster-logo.react.js
7–28 ↗	(On Diff #38418)	Seems like this would be an easy one to memoize

This revision is now accepted and ready to land.Mar 28 2024, 12:50 PM

address feedback

ginsu added a child revision: D11441: [native] introduce FarcasterPrompt.Mar 28 2024, 4:28 PM

Harbormaster completed remote builds in B27775: Diff 38465.Mar 28 2024, 4:38 PM

Closed by commit rCOMM3941d90cb605: [native] introduce FarcasterLogo. · Explain WhyMar 28 2024, 5:58 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM3941d90cb605: [native] introduce FarcasterLogo.

[native] introduce FarcasterLogo
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 38485

native/vectors/farcaster-logo.react.js

[native] introduce FarcasterLogoClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38485

native/vectors/farcaster-logo.react.js

[native] introduce FarcasterLogo
ClosedPublic
Actions

Revision Contents
Changeset List