Page MenuHomePhabricator

[native] unauth from farcaster
ClosedPublic

Authored by ginsu on Apr 1 2024, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:45 AM
Unknown Object (File)
Tue, Nov 12, 10:55 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 11 2024, 11:16 AM
Subscribers

Details

Summary

This diff handles unauthing from farcaster. We handle unauthing from farcaster by removing the set fid from the farcaster provider. There is a task to handle updating this to replace all FIDProvider usages with synced metadata store tracked here: https://linear.app/comm/issue/ENG-7590/replace-all-fidprovider-usages-with-synced-metadata-store

cc @will

Depends on D11512

Test Plan

Confirmed that the fid is getting unset when onPressDisconnect is getting called

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added a reviewer: atul.
ginsu added a subscriber: will.
ginsu requested review of this revision.Apr 1 2024, 12:47 PM
atul added inline comments.
native/profile/farcaster-account-settings.react.js
31–33 ↗(On Diff #38638)

Wonder what would happen if you passed in setFID as prop directly? I guess it would call setFID(undefined) or something?

Either way, this is more readable + explicit + etc.

This revision is now accepted and ready to land.Apr 1 2024, 12:53 PM

rebase before landing + confirm keyserver ci build works

This revision was automatically updated to reflect the committed changes.