Page MenuHomePhabricator
Differential D11513

[native] unauth from farcaster
ClosedPublic
Actions

Authored by ginsu on Apr 1 2024, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 3:32 PM
Unknown Object (File)
Tue, May 7, 3:32 PM
Unknown Object (File)
Tue, May 7, 3:32 PM
Unknown Object (File)
Tue, May 7, 3:31 PM
Unknown Object (File)
Apr 12 2024, 8:55 AM
Unknown Object (File)
Apr 12 2024, 5:54 AM
Unknown Object (File)
Apr 11 2024, 8:06 PM
Unknown Object (File)
Apr 11 2024, 1:45 AM
View All 19 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
Commits
rCOMM296be49bd4b4: [native] unauth from farcaster
Summary

This diff handles unauthing from farcaster. We handle unauthing from farcaster by removing the set fid from the farcaster provider. There is a task to handle updating this to replace all FIDProvider usages with synced metadata store tracked here: https://linear.app/comm/issue/ENG-7590/replace-all-fidprovider-usages-with-synced-metadata-store

cc @will

Depends on D11512

Test Plan

Confirmed that the fid is getting unset when onPressDisconnect is getting called

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 1 2024, 12:32 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 1 2024, 12:32 PM
ginsu edited the summary of this revision. (Show Details)Apr 1 2024, 12:34 PM
ginsu added a reviewer: atul.
ginsu added a parent revision: D11512: [native] build out UI for farcaster account settings screen.
ginsu added a subscriber: will.
Harbormaster completed remote builds in B27896: Diff 38638.Apr 1 2024, 12:47 PM
ginsu requested review of this revision.Apr 1 2024, 12:47 PM
atul accepted this revision.Apr 1 2024, 12:53 PM
atul added inline comments.
native/profile/farcaster-account-settings.react.js
31–33 ↗(On Diff #38638)

Wonder what would happen if you passed in setFID as prop directly? I guess it would call setFID(undefined) or something?

Either way, this is more readable + explicit + etc.

This revision is now accepted and ready to land.Apr 1 2024, 12:53 PM
ginsu updated this revision to Diff 38686.Apr 2 2024, 10:27 PM

rebase before landing

Harbormaster failed remote builds in B27924: Diff 38686!Apr 2 2024, 10:28 PM
ginsu updated this revision to Diff 38741.Apr 3 2024, 9:26 AM

rebase before landing + confirm keyserver ci build works

Harbormaster completed remote builds in B27961: Diff 38741.Apr 3 2024, 9:45 AM
Closed by commit rCOMM296be49bd4b4: [native] unauth from farcaster (authored by ginsu). · Explain WhyApr 3 2024, 9:49 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM296be49bd4b4: [native] unauth from farcaster.

Revision Contents
Changeset List

PathSize
native/
profile/
4 lines

Diff 38745

View Options

native/profile/farcaster-account-settings.react.js

Loading...