Paths

Table of Contentst

Differential D11461

[native] add the connect farcaster step into the registration flow
ClosedPublic
Actions

Authored by ginsu on Mar 28 2024, 9:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 10:42 PM

	Unknown Object (File)
	Wed, Nov 13, 12:45 AM

	Unknown Object (File)
	Tue, Nov 12, 10:55 PM

	Unknown Object (File)
	Oct 22 2024, 2:44 PM

	Unknown Object (File)
	Oct 18 2024, 6:25 PM

	Unknown Object (File)
	Oct 18 2024, 6:25 PM

	Unknown Object (File)
	Oct 18 2024, 6:25 PM

	Unknown Object (File)
	Oct 11 2024, 11:16 AM

View All 52 Files

Subscribers

Details

Reviewers

Commits

rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow

Summary

This diff adds the ConnectFarcaster screen into the registration flow. We want to show the connect farcaster screen after the connect etherum screen.

In this diff we also need to add an optional fid field to Params of all the screens after connect farcaster + RegistrationServerCallInput in order to potentially pass an fid through the registration flow

Depends on D11442

Test Plan

Please see the demo video below + tested the entire sign in flow during the hackathon

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 28 2024, 9:25 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 9:25 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 9:27 PM

Harbormaster failed remote builds in B27802: Diff 38519!

ginsu edited the summary of this revision. (Show Details)Mar 28 2024, 9:36 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a reviewer: atul.

ginsu added a parent revision: D11442: [native] introduce ConnectFarcaster registration screen.

fix? (ran yarn cleaninstall to try and fix keyserver build)

ginsu attached a referenced file: F1440207: Screen Recording 2024-03-29 at 12.30.59 AM.mov. (Show Details)Mar 28 2024, 9:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 9:43 PM

Harbormaster failed remote builds in B27803: Diff 38520!

will make sure ci passes before landing

ginsu requested review of this revision.Mar 28 2024, 9:45 PM

ginsu added a child revision: D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.

atul accepted this revision.Mar 29 2024, 1:18 PM

This revision is now accepted and ready to land.Mar 29 2024, 1:18 PM

Harbormaster completed remote builds in B27803: Diff 38520.Mar 29 2024, 2:14 PM

Closed by commit rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow (authored by ginsu). · Explain WhyMar 29 2024, 2:20 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

avatar-selection.react.js

1 line

connect-ethereum.react.js

21 lines

connect-farcaster.react.js

61 lines

keyserver-selection.react.js

8 lines

password-selection.react.js

6 lines

registration-terms.react.js

1 line

registration-types.js

1 line

username-selection.react.js

1 line

Diff 38520

native/account/registration/avatar-selection.react.js

Loading...

native/account/registration/connect-ethereum.react.js

Loading...

native/account/registration/connect-farcaster.react.js

Loading...

native/account/registration/keyserver-selection.react.js

Loading...

native/account/registration/password-selection.react.js

Loading...

native/account/registration/registration-terms.react.js

Loading...

native/account/registration/registration-types.js

Loading...

native/account/registration/username-selection.react.js

Loading...