Page MenuHomePhabricator
Differential D11530

[scripts] Improve prompt
ClosedPublic
Actions

Authored by inka on Wed, Apr 3, 1:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 1:28 AM
Unknown Object (File)
Wed, Apr 17, 10:52 AM
Unknown Object (File)
Wed, Apr 17, 9:20 AM
Unknown Object (File)
Wed, Apr 17, 7:56 AM
Unknown Object (File)
Tue, Apr 16, 10:00 PM
Unknown Object (File)
Tue, Apr 16, 9:35 AM
Unknown Object (File)
Mon, Apr 15, 6:36 PM
Unknown Object (File)
Sat, Apr 13, 7:21 AM
View All 13 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
kamil
Commits
rCOMM99d77585156c: [scripts] Improve prompt
Summary

issue: ENG-7310
The admin of the new keyserver has to be a user that was not an admin befroe. They don't have to exist on the identity service though, registration will be attempted

Test Plan

Ran nix develop, typed y and checked that the propmt is printed correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Wed, Apr 3, 1:49 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Apr 3, 1:49 AM
Harbormaster completed remote builds in B27927: Diff 38699.Wed, Apr 3, 2:05 AM
inka requested review of this revision.Wed, Apr 3, 2:05 AM
tomek added inline comments.Wed, Apr 3, 2:10 AM
scripts/set-user-credentials.js
30 ↗(On Diff #38699)
kamil resigned from this revision.Wed, Apr 3, 5:17 AM

LGTM but leaving final review to native speaker

scripts/set-user-credentials.js
32 ↗(On Diff #38699)
inka added a child revision: D11540: [keyserver] Refactor registerOrLogIn to take callbacks.Wed, Apr 3, 6:36 AM
will accepted this revision.Wed, Apr 3, 12:42 PM

Prompt reads pretty clear to me

scripts/set-user-credentials.js
31 ↗(On Diff #38699)
This revision is now accepted and ready to land.Wed, Apr 3, 12:42 PM
inka updated this revision to Diff 38767.Thu, Apr 4, 5:36 AM

Address review

Harbormaster completed remote builds in B27970: Diff 38767.Thu, Apr 4, 5:52 AM
Closed by commit rCOMM99d77585156c: [scripts] Improve prompt (authored by inka). · Explain WhyFri, Apr 5, 5:58 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM99d77585156c: [scripts] Improve prompt.

Revision Contents
Changeset List

PathSize
scripts/
8 lines

Diff 38857

View Options

scripts/set-user-credentials.js

Loading...