[scripts] Improve prompt
ClosedPublic
Actions

Authored by inka on Apr 3 2024, 1:49 AM.

Details

Reviewers

will
kamil

Commits

rCOMM99d77585156c: [scripts] Improve prompt

Summary

issue: ENG-7310
The admin of the new keyserver has to be a user that was not an admin befroe. They don't have to exist on the identity service though, registration will be attempted

Test Plan

Ran nix develop, typed y and checked that the propmt is printed correctly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Apr 3 2024, 1:49 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2024, 1:49 AM

Harbormaster completed remote builds in B27927: Diff 38699.Apr 3 2024, 2:05 AM

inka requested review of this revision.Apr 3 2024, 2:05 AM

tomek added inline comments.Apr 3 2024, 2:10 AM

scripts/set-user-credentials.js
30 ↗	(On Diff #38699)

LGTM but leaving final review to native speaker

scripts/set-user-credentials.js
32 ↗	(On Diff #38699)

inka added a child revision: D11540: [keyserver] Refactor registerOrLogIn to take callbacks.Apr 3 2024, 6:36 AM

Prompt reads pretty clear to me

scripts/set-user-credentials.js
31 ↗	(On Diff #38699)

This revision is now accepted and ready to land.Apr 3 2024, 12:42 PM

Address review

Harbormaster completed remote builds in B27970: Diff 38767.Apr 4 2024, 5:52 AM

Closed by commit rCOMM99d77585156c: [scripts] Improve prompt (authored by inka). · Explain WhyApr 5 2024, 5:58 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM99d77585156c: [scripts] Improve prompt.

Revision Contents
Changeset List

Path

Size

scripts/

set-user-credentials.js

8 lines

Diff 38857

View Options

scripts/set-user-credentials.js

[scripts] Improve promptClosedPublicActions