Updates in-memory CryptoModule to work with session versions.
Depends on D11580
Details
Details
Tested in TBD
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp | ||
|---|---|---|
| 79 ↗ | (On Diff #38904) | for notifs it's hardcoded now - we should update this in the future while working at [ENG-7658](https://linear.app/comm/issue/ENG-7658/add-olm-session-versioning-for-notifs |
| native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp | ||
|---|---|---|
| 79 ↗ | (On Diff #38904) | This code is only used to migrate old way of persisting session. Currently we serialize and persist the following JSON to MMKV: {
"session":<session bytes>
"picklingKey": <picklingKey>
}That said we need to update this JSON to have version field as well. |
| native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp | ||
|---|---|---|
| 79 ↗ | (On Diff #38904) | since this value will be hardcoded for notifs - can we just ignore updating JSON and add it when it is needed? Not sure what could we gain from persisting mock value in MMKV |
| native/cpp/CommonCpp/CryptoTools/Session.h | ||
|---|---|---|
| 17 ↗ | (On Diff #38911) | Nit: Could we make it private and introduce getter? |