Paths

Table of Contentst

Differential D11594

[lib] errors utils to distinguish between session creation issues
ClosedPublic
Actions

Authored by kamil on Apr 9 2024, 10:26 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
marcin
tomek

Commits

rCOMMf4b392ccb485: [lib] errors utils to distinguish between session creation issues

Summary

Constants with errors introduced earlier in the stack.

Depends on D11591

Test Plan

Tested all error cases on both web and native

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 9 2024, 10:26 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2024, 10:27 AM

Harbormaster completed remote builds in B28076: Diff 38926.Apr 9 2024, 10:42 AM

kamil added a child revision: D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.Apr 9 2024, 11:44 AM

kamil published this revision for review.Apr 9 2024, 1:03 PM

kamil added inline comments.

lib/handlers/peer-to-peer-message-handler.js
45 ↗	(On Diff #38926)	handled in D11596
lib/utils/errors.js
49 ↗	(On Diff #38926)	added by IDE, I'll remove it before landing

ashoat added inline comments.Apr 10 2024, 2:51 PM

lib/utils/errors.js
74–81 ↗	(On Diff #38926)	Should this have been introduced in D11595, and used there in `worker-crypto.js`? I think it's weird to add these Olm-specific errors to a file that otherwise is fairly generic. Can you find a different place for them?

ashoat added inline comments.Apr 10 2024, 2:53 PM

lib/utils/errors.js
74–81 ↗	(On Diff #38926)	Ignore point 1, I didn't realize this is earlier in the stack. Will follow up about using the constants on the linked diff Point 2 still stands

Please address @ashoat suggestion before landing.

This revision is now accepted and ready to land.Apr 11 2024, 7:49 AM

move olmSessionErrors from errors.js to olm-utils.js

Harbormaster completed remote builds in B28162: Diff 39036.Apr 11 2024, 11:24 AM

Closed by commit rCOMMf4b392ccb485: [lib] errors utils to distinguish between session creation issues. · Explain WhyApr 11 2024, 11:47 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf4b392ccb485: [lib] errors utils to distinguish between session creation issues.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

peer-to-peer-message-handler.js

35 lines

utils/

10 lines

Diff 39046

lib/handlers/peer-to-peer-message-handler.js

Loading...

lib/utils/olm-utils.js

Loading...